Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN][0.74]Fix XROS build #45580

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[RN][0.74]Fix XROS build #45580

merged 1 commit into from
Jul 23, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jul 22, 2024 •
edited
Loading

Summary:

Fix the CI build for XROS

Changelog:

[Internal] - Fix XROS build

Test Plan:

CCI is green

@cipolleschi cipolleschi changed the base branch from main to 0.74-stable July 22, 2024 16:36
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 22, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-xros-build branch 2 times, most recently from 3eb5c71 to 3a33458 Compare July 22, 2024 17:03
@analysis-bot
Copy link

analysis-bot commented Jul 22, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,857,515 -3,497,341
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,211,592 -3,338,399
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-xros-build branch 2 times, most recently from 96a1bb1 to 2e0c759 Compare July 23, 2024 09:29
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-xros-build branch from 2e0c759 to 866d158 Compare July 23, 2024 10:01
@cipolleschi cipolleschi marked this pull request as ready for review July 23, 2024 11:36
@Titozzz Titozzz merged commit 1835245 into 0.74-stable Jul 23, 2024
55 checks passed
@cipolleschi cipolleschi mentioned this pull request Jul 31, 2024
Merged
@cortinico cortinico deleted the cipolleschi/fix-xros-build branch November 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
5 participants
@cipolleschi @analysis-bot @Titozzz @facebook-github-bot @react-native-bot