-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using Cocoapods 1.15 until it fixes an issue affection RN. #42702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Jan 29, 2024
Summary: Users aren't able to build (#42698). We're restricting the version to known good version of Cocoapods until the next release. Changelog: [iOS][Fixed] don't allow cocoapods 1.15.
blakef
force-pushed
the
fix-limit-cocoapods
branch
from
January 29, 2024 11:32
831ba71
to
91125b0
Compare
blakef
changed the title
Create a test that Expo's nightlies trigger with an outcome
Avoid using Cocoapods 1.15 until it fixes an issue affection RN.
Jan 29, 2024
cipolleschi
approved these changes
Jan 29, 2024
Good job, thanks for doing this! |
Base commit: cfc0ba0 |
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
blakef
added a commit
that referenced
this pull request
Jan 29, 2024
) Summary: Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15 This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3. [iOS][Fixed] don't allow cocoapods 1.15. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #42702 Test Plan: ``` bundle exec pod install ``` Reviewed By: cipolleschi Differential Revision: D53180111 Pulled By: blakef fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
huntie
pushed a commit
that referenced
this pull request
Jan 29, 2024
) Summary: Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15 This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3. ## Changelog: [iOS][Fixed] don't allow cocoapods 1.15.
hurali97
added a commit
that referenced
this pull request
Jan 29, 2024
) Summary: Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15 This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3. [iOS][Fixed] don't allow cocoapods 1.15. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #42702 Test Plan: ``` bundle exec pod install ``` Reviewed By: cipolleschi Differential Revision: D53180111 Pulled By: blakef fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
Not only. This blocks also 0.72.6. I think this is a general problem |
hurali97
added a commit
that referenced
this pull request
Jan 29, 2024
Cherry-picking 'Avoid using Cocoapods 1.15 until it fixes an issue affection RN. (#42702)' onto 0.71
blakef
added a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
…702) Summary: Cocoapods 1.15 (facebook/react-native#42698) current breaks the build, limit to version >= 1.13 & < 1.15 This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3. ## Changelog: [iOS][Fixed] don't allow cocoapods 1.15. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook/react-native#42702 Test Plan: ``` bundle exec pod install ``` Reviewed By: cipolleschi Differential Revision: D53180111 Pulled By: blakef fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd Original: facebook/react-native@3869ae4
This was referenced Feb 29, 2024
blakef
added a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
…702) Summary: Cocoapods 1.15 (facebook/react-native#42698) current breaks the build, limit to version >= 1.13 & < 1.15 This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3. ## Changelog: [iOS][Fixed] don't allow cocoapods 1.15. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook/react-native#42702 Test Plan: ``` bundle exec pod install ``` Reviewed By: cipolleschi Differential Revision: D53180111 Pulled By: blakef fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd Original-Commit: facebook/react-native@3869ae4
blakef
added a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
…702) Summary: Cocoapods 1.15 (facebook/react-native#42698) current breaks the build, limit to version >= 1.13 & < 1.15 This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3. ## Changelog: [iOS][Fixed] don't allow cocoapods 1.15. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook/react-native#42702 Test Plan: ``` bundle exec pod install ``` Reviewed By: cipolleschi Differential Revision: D53180111 Pulled By: blakef fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd Original-Commit: facebook/react-native@3869ae4
This was referenced Mar 6, 2024
This was referenced Apr 5, 2024
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Apr 18, 2024
Summary: Previously we had to limit (facebook#42702) Cocoapods to avoid a broken version, this is no longer the case. Changelog: [iOS][Changed] - Remove limit on Cocoapods to allow 1.15.2 Differential Revision: D56299927
blakef
added a commit
to blakef/react-native
that referenced
this pull request
Apr 18, 2024
Summary: Previously we had to limit (facebook#42702) Cocoapods to avoid a broken version, this is no longer the case. Changelog: [iOS][Changed] - Remove limit on Cocoapods to allow 1.15.2 Differential Revision: D56299927
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15
Summary:
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
Changelog:
[iOS][Fixed] don't allow cocoapods 1.15.
Test Plan: