Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cocoapods 1.15.2 which fixes #42698 #44143

Closed
wants to merge 1 commit into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Apr 18, 2024

Summary:
Previously we had to limit (#42702) Cocoapods to avoid a broken version, this is no longer the case.

Changelog: [iOS][Changed] - Remove limit on Cocoapods to allow 1.15.2

Differential Revision: D56299927

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56299927

Summary:

Previously we had to limit (facebook#42702) Cocoapods to avoid a broken version, this is no longer the case.

Changelog: [iOS][Changed] - Remove limit on Cocoapods to allow 1.15.2

Differential Revision: D56299927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56299927

@blakef
Copy link
Contributor Author

blakef commented Apr 18, 2024

I'm going to abandon this. @cipolleschi made a good point, which is that 1.15.1 doesn't add anything we need. 1.15.2 removes / fixes some of the things that broke in that release. So until Cocoapods add something we need there isn't much point undoing the restriction

@blakef blakef closed this Apr 18, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,394,177 -16
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,767,802 -9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f21d9af
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants