Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old architecture pipeline for RNTester #42245

Closed
wants to merge 1 commit into from
Closed

remove old architecture pipeline for RNTester #42245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .circleci/configurations/jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,11 +503,6 @@ jobs:
description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
type: enum
enum: ["Hermes", "JSC"]
architecture:
default: "OldArch"
description: Which React Native architecture to use. Must be one of "OldArch", "NewArch".
type: enum
enum: ["NewArch", "OldArch"]
use_frameworks:
default: "StaticLibraries"
description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
Expand Down Expand Up @@ -550,11 +545,8 @@ jobs:
- with_xcodebuild_cache:
steps:
- run:
name: Install CocoaPods dependencies - Architecture << parameters.architecture >>
name: Install CocoaPods dependencies
command: |
if [[ << parameters.architecture >> == "NewArch" ]]; then
export RCT_NEW_ARCH_ENABLED=1
fi

if [[ << parameters.jsengine >> == "JSC" ]]; then
export USE_HERMES=0
Expand All @@ -564,8 +556,9 @@ jobs:
export USE_FRAMEWORKS=dynamic
fi

export RCT_NEW_ARCH_ENABLED=1
cd packages/rn-tester

bundle install
bundle exec pod install
- when:
Expand Down
3 changes: 0 additions & 3 deletions .circleci/configurations/test_workflows/testAll.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@
- build_hermes_macos
name: "Test RNTester with Ruby 3.2.0"
ruby_version: "3.2.0"
architecture: "NewArch"
executor: reactnativeios-lts
- test_ios_rntester:
architecture: "NewArch"
requires:
- build_hermes_macos
matrix:
Expand All @@ -108,5 +106,4 @@
- build_hermes_macos
matrix:
parameters:
architecture: ["OldArch", "NewArch"]
jsengine: ["Hermes", "JSC"]
3 changes: 0 additions & 3 deletions .circleci/configurations/test_workflows/testIOS.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,8 @@
- build_hermes_macos
name: "Test RNTester with Ruby 3.2.0"
ruby_version: "3.2.0"
architecture: "NewArch"
executor: reactnativeios-lts
- test_ios_rntester:
architecture: "NewArch"
requires:
- build_hermes_macos
matrix:
Expand All @@ -99,5 +97,4 @@
- build_hermes_macos
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
jsengine: ["Hermes", "JSC"]
Loading