Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old architecture pipeline for RNTester #42245

Closed
wants to merge 1 commit into from
Closed

remove old architecture pipeline for RNTester #42245

wants to merge 1 commit into from

Conversation

okwasniewski
Copy link
Contributor

Summary:

As discussed with @cipolleschi, RNTester shouldn't be tested for Old Arch. This PR removes those unnecessary pipeline runs

Changelog:

[INTERNAL] [REMOVED] - remove old architecture pipeline for RNTester

Test Plan:

CI Green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 11, 2024
cipolleschi
cipolleschi requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of lines that are changed but that are related to the template. That needs to be restored.
After that, it is good to go!

.circleci/configurations/test_workflows/testAll.yml Outdated Show resolved Hide resolved
.circleci/configurations/test_workflows/testAll.yml Outdated Show resolved Hide resolved
@okwasniewski okwasniewski force-pushed the feat/rntester-old-arch-ci branch from 273c36d to 0251475 Compare January 11, 2024 13:50
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,769,606 -21,663
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,165,561 -21,053
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: abad576
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 11, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 3630138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okwasniewski @facebook-github-bot @analysis-bot @cipolleschi