Allow non-static LongLivedObjectCollections in TurboModuleBinding #42194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
Base commit: a9a736f |
rozele
force-pushed
the
export-D52581170
branch
from
a607a1b to
7a76394
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Differential Revision: D52581170
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
7a76394 to
69a7e21
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Differential Revision: D52581170
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
force-pushed
the
export-D52581170
branch
from
69a7e21 to
e91b114
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Pull Request resolved: facebook#42194 Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Differential Revision: D52581170 fbshipit-source-id: db5991ad75094bd8c9bcabde94da62ac9c87ab00
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
e91b114 to
0102d44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
0102d44 to
5adfb88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
5adfb88 to
eef1279
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
eef1279 to
01ac7eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
01ac7eb to
f296e2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
f296e2c to
200780d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
200780d to
6e082b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
…cebook#42194) Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170
rozele
force-pushed
the
export-D52581170
branch
from
6e082b7 to
11279ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52581170 |
|
This pull request has been merged in f7f9250. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…cebook#42194) Summary: Pull Request resolved: facebook#42194 Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170 fbshipit-source-id: 791e3baeefaf23f544eeddd5a216735535523a9d
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
…cebook#42194) Summary: Pull Request resolved: facebook#42194 Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files [here](https://github.com/microsoft/react-native-windows/tree/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/nativemodule/core/ReactCommon) for the reasons already mentioned) to manage per instance LongLivedObjectCollections. ## Changelog [Internal] Reviewed By: christophpurrer Differential Revision: D52581170 fbshipit-source-id: 791e3baeefaf23f544eeddd5a216735535523a9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Apps that have multiple concurrently running React instances may suffer from issues where tearing down one instance affects the bindings / LongLivedObjectCollection instance of another due to the use of static getter for LongLivedObjectCollection. This should allow host platforms, e.g., react-native-windows (which still forks the TurboModuleBinding C++ files here for the reasons already mentioned) to manage per instance LongLivedObjectCollections.
Differential Revision: D52581170