-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forks of TurboModuleBinding/LongLivedObject #11019
Comments
@vmoroz I believe you were working on getting these changes to longLivedObjectCollection added back into upstream since we use it in Office code but correct me if I'm wrong! Recent integration brought in JavaTurboModule/LongLivedObject cleanup which caused us to fork more files in ReactCommon. Adding these forked files to this issue so they're on your radar. |
Thanks! I still need to go to the RN repo and undo their changes. |
@vmoroz @TatianaKapos is this what you're looking for: facebook/react-native#42194 ? |
Problem Description
Recent integration pulling in Remove ObjCTurboModule experiments with retaining JS callbacks in custom scopes removed JS callbacks which we use. Removing the overrides cause JsiSimpleTurboModuleTests to fail. Will need to refactor our code to adjust to new method declarations.
Steps To Reproduce
Expected Results
Tests to pass
CLI version
npx react-native --version
Environment
Target Platform Version
10.0.19041
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2022
Build Configuration
Debug
Snack, code example, screenshot, or link to a repository
No response
The text was updated successfully, but these errors were encountered: