remove unused methodQueue from RCTHTTPRequestHandler #41136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50525900 |
Base commit: 1923a4e |
philIip
force-pushed
the
export-D50525900
branch
from
c572643 to
3aacf8e
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Changelog: [iOS][Breaking] You cannot call methodQueue on RCTHTTPRequestHandler the `synthesize methodQueue` API is confusing, it looks like an API only for use within native module implementation, but it's actually needed to create a selector that corresponds to the property declared in the `RCTBridgeModule` public protocol. no one is using the `methodQueue` on `RCTHTTPRequestHandler`, so let's get rid of the public access to it. Reviewed By: javache, cipolleschi Differential Revision: D50525900
|
This pull request was exported from Phabricator. Differential Revision: D50525900 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 23, 2023
Summary: Changelog: [iOS][Breaking] You cannot call methodQueue on RCTHTTPRequestHandler the `synthesize methodQueue` API is confusing, it looks like an API only for use within native module implementation, but it's actually needed to create a selector that corresponds to the property declared in the `RCTBridgeModule` public protocol. no one is using the `methodQueue` on `RCTHTTPRequestHandler`, so let's get rid of the public access to it. Reviewed By: javache, cipolleschi Differential Revision: D50525900
philIip
force-pushed
the
export-D50525900
branch
from
3aacf8e to
ab89c92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50525900 |
Summary: Changelog: [iOS][Breaking] You cannot call methodQueue on RCTHTTPRequestHandler the `synthesize methodQueue` API is confusing, it looks like an API only for use within native module implementation, but it's actually needed to create a selector that corresponds to the property declared in the `RCTBridgeModule` public protocol. no one is using the `methodQueue` on `RCTHTTPRequestHandler`, so let's get rid of the public access to it. Reviewed By: javache, cipolleschi Differential Revision: D50525900
philIip
force-pushed
the
export-D50525900
branch
from
ab89c92 to
01c8861
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50525900 |
|
This pull request was successfully merged by @philIip in 7503dbd. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#41136 Changelog: [iOS][Breaking] You cannot call methodQueue on RCTHTTPRequestHandler the `synthesize methodQueue` API is confusing, it looks like an API only for use within native module implementation, but it's actually needed to create a selector that corresponds to the property declared in the `RCTBridgeModule` public protocol. no one is using the `methodQueue` on `RCTHTTPRequestHandler`, so let's get rid of the public access to it. Reviewed By: javache, cipolleschi Differential Revision: D50525900 fbshipit-source-id: f83738491d0eadc71a6dc3194ee16fe7c8748263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Breaking] You cannot call methodQueue on RCTHTTPRequestHandler
the
synthesize methodQueueAPI is confusing, it looks like an API only for use within native module implementation, but it's actually needed to create a selector that corresponds to the property declared in theRCTBridgeModulepublic protocol.no one is using the
methodQueueonRCTHTTPRequestHandler, so let's get rid of the public access to it.Differential Revision: D50525900