Skip to content

Commit

Permalink
remove unused methodQueue from RCTHTTPRequestHandler (facebook#41136)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#41136

Changelog: [iOS][Breaking] You cannot call methodQueue on RCTHTTPRequestHandler

the `synthesize methodQueue` API is confusing, it looks like an API only for use within native module implementation, but it's actually needed to create a selector that corresponds to the property declared in the `RCTBridgeModule` public protocol.

no one is using the `methodQueue`  on `RCTHTTPRequestHandler`, so let's get rid of the public access to it.

Reviewed By: javache, cipolleschi

Differential Revision: D50525900

fbshipit-source-id: f83738491d0eadc71a6dc3194ee16fe7c8748263
  • Loading branch information
philIip authored and Othinn committed Oct 30, 2023
1 parent 9a5806f commit 064bc2e
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ @implementation RCTHTTPRequestHandler {
}

@synthesize moduleRegistry = _moduleRegistry;
@synthesize methodQueue = _methodQueue;

RCT_EXPORT_MODULE()

Expand Down

0 comments on commit 064bc2e

Please sign in to comment.