Fix local e2e script by copying the hermes' ruby files to the right folder #39580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49497716 |
…older (facebook#39580) Summary: While testing other features, I realized that the script to generate a project locally, starting from the template, has a bug for which we were using the outdated `hermes-engine.podspec` coming from the Hermes repo to build hermes. This change fixes this by moving our files to the right folder. ## Changelog: [Internal] - Fix local e2e test script copying hermes rubyscript over Reviewed By: dmytrorykun Differential Revision: D49497716
cipolleschi
force-pushed
the
export-D49497716
branch
from
7b0e052 to
cd104a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49497716 |
Base commit: 780567c |
|
This pull request has been merged in 42d090c. |
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
…older (facebook#39580) Summary: Pull Request resolved: facebook#39580 While testing other features, I realized that the script to generate a project locally, starting from the template, has a bug for which we were using the outdated `hermes-engine.podspec` coming from the Hermes repo to build hermes. This change fixes this by moving our files to the right folder. ## Changelog: [Internal] - Fix local e2e test script copying hermes rubyscript over Reviewed By: dmytrorykun Differential Revision: D49497716 fbshipit-source-id: f1d582ec9d9c8007cbd2f9c876c061af12735f83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While testing other features, I realized that the script to generate a project locally, starting from the template, has a bug for which we were using the outdated
hermes-engine.podspeccoming from the Hermes repo to build hermes.This change fixes this by moving our files to the right folder.
Changelog:
[Internal] - Fix local e2e test script copying hermes rubyscript over
Reviewed By: dmytrorykun
Differential Revision: D49497716