Bump IPHONEOS_DEPLOYMENT_TARGET to 13.4 for 3rd party pods #39478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49274837 |
…39478) Summary: When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. ## Changelog: [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Reviewed By: dmytrorykun Differential Revision: D49274837
cipolleschi
force-pushed
the
export-D49274837
branch
from
e9add5b
to
de7c8f6
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
…39478) Summary: When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. ## Changelog: [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Reviewed By: dmytrorykun Differential Revision: D49274837
|
This pull request was exported from Phabricator. Differential Revision: D49274837 |
cipolleschi
force-pushed
the
export-D49274837
branch
from
de7c8f6
to
a2de047
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49274837 |
|
This pull request has been merged in 21763e8. |
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39478 When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Reviewed By: dmytrorykun Differential Revision: D49274837 fbshipit-source-id: 584d105c76d654daa2ecf5eb2f1b9381e70f567a
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39478 When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Reviewed By: dmytrorykun Differential Revision: D49274837 fbshipit-source-id: 584d105c76d654daa2ecf5eb2f1b9381e70f567a
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39478 When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Reviewed By: dmytrorykun Differential Revision: D49274837 fbshipit-source-id: 584d105c76d654daa2ecf5eb2f1b9381e70f567a
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39478 When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Reviewed By: dmytrorykun Differential Revision: D49274837 fbshipit-source-id: 584d105c76d654daa2ecf5eb2f1b9381e70f567a
This was referenced Sep 21, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
Summary: While merging new commits into React Native macOS, I noticed #39478 I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream ## Changelog: [Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget Pull Request resolved: #39570 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49514693 Pulled By: ryancat fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
…39570) Summary: While merging new commits into React Native macOS, I noticed facebook#39478 I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream ## Changelog: [Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget Pull Request resolved: facebook#39570 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49514693 Pulled By: ryancat fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d
This was referenced Oct 11, 2023
Merged
This was referenced Nov 1, 2023
This was referenced Jan 4, 2024
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 19, 2024
…39570) Summary: While merging new commits into React Native macOS, I noticed facebook#39478 I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream [Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget Pull Request resolved: facebook#39570 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49514693 Pulled By: ryancat fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d
Saadnajmi
added a commit
to microsoft/react-native-macos
that referenced
this pull request
Jan 20, 2024
) * updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget (facebook#39570) Summary: While merging new commits into React Native macOS, I noticed facebook#39478 I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream [Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget Pull Request resolved: facebook#39570 Test Plan: CI should pass Reviewed By: NickGerleman Differential Revision: D49514693 Pulled By: ryancat fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d * min_ios_version_supported -> min_supported_versions (facebook#39310) Summary: One of the most common diffs we have in React Native macOS is simply extending the `platforms` key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define a `min_supported_versions` hash that can be overridden at one place that is extensible to more platforms, instead of just specifying `min_ios_version_supported`. Note: In doing this change, I have set it that `React-Hermes.podspec` doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back? [IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts Pull Request resolved: facebook#39310 Test Plan: CI should pass. Reviewed By: NickGerleman Differential Revision: D49014109 Pulled By: dmytrorykun fbshipit-source-id: d44fc7b750c70cc263a2c89502c022a0db9a4771 * Set macOS deployment target
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS.
We can update that setting to silence the warning with Cocoapods and this is what this script does.
Notice that bumping that setting generated other warning as some APIs have been deprecated.
Changelog:
[Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods
Reviewed By: dmytrorykun
Differential Revision: D49274837