Skip to content

Commit

Permalink
updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget (#39570)
Browse files Browse the repository at this point in the history
Summary:
While merging new commits into React Native macOS, I noticed #39478

I would like to also set `MACOS_DEPLOYMENT_TARGET` in our fork, and thought this slight rename would be something I can do upstream

## Changelog:

[Internal] - updateIphoneOSDeploymentTarget -> updateOSDeploymentTarget

Pull Request resolved: #39570

Test Plan: CI should pass

Reviewed By: NickGerleman

Differential Revision: D49514693

Pulled By: ryancat

fbshipit-source-id: b4dafb1f9736d2977510712652cb8097263c489d
  • Loading branch information
Saadnajmi authored and facebook-github-bot committed Sep 22, 2023
1 parent 7a8251e commit 8fa1127
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/react-native/scripts/cocoapods/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def self.update_search_paths(installer)
end
end

def self.updateIphoneOSDeploymentTarget(installer)
def self.updateOSDeploymentTarget(installer)
pod_to_update = Set.new([
"boost",
"CocoaAsyncSocket",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/react_native_pods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def react_native_post_install(
ReactNativePodsUtils.apply_flags_for_fabric(installer, fabric_enabled: fabric_enabled)
ReactNativePodsUtils.apply_xcode_15_patch(installer)
ReactNativePodsUtils.apply_ats_config(installer)
ReactNativePodsUtils.updateIphoneOSDeploymentTarget(installer)
ReactNativePodsUtils.updateOSDeploymentTarget(installer)

NewArchitectureHelper.set_clang_cxx_language_standard_if_needed(installer)
NewArchitectureHelper.modify_flags_for_new_architecture(installer, NewArchitectureHelper.new_arch_enabled)
Expand Down

0 comments on commit 8fa1127

Please sign in to comment.