Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 15 RC issues #39474

Closed
wants to merge 2 commits into from
Closed

Fix Xcode 15 RC issues #39474

wants to merge 2 commits into from

Commits on Sep 18, 2023

  1. Bump IPHONEOS_DEPLOYMENT_TARGET to 13.4 for 3rd party pods 

    Summary:
When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS.
We can update that setting to silence the warning with Cocoapods and this is what this script does.

Notice that bumping that setting generated other warning as some APIs have been deprecated.

## Changelog:
[Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods

Differential Revision: D49274837

fbshipit-source-id: ae0f2dfe05df2d38b081aebbb2481413a0a9fef1
    @facebook-github-bot
    Riccardo Cipolleschi authored and facebook-github-bot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6b6ce6e View commit details
    Browse the repository at this point in the history

  2. Fix Xcode 15 RC issues (facebook#39474) 

    Summary:
Pull Request resolved: facebook#39474

When it comes to Xcode 15 RC, we are aware of two issues:
1. `unary_function` and `binary_function` not available in Cxx17
2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore.

This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected.

## Changelog:
[Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed

Reviewed By: dmytrorykun

Differential Revision: D49319256

fbshipit-source-id: 02d642645cfcfec968d3ebfb319ab635115f8b12
    @cipolleschi @facebook-github-bot
    cipolleschi authored and facebook-github-bot committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    7fb938c View commit details
    Browse the repository at this point in the history