Fix Xcode 15 RC issues #39474
Closed
Fix Xcode 15 RC issues #39474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49319256 |
|
This pull request was exported from Phabricator. Differential Revision: D49319256 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39474 When it comes to Xcode 15 RC, we are aware of two issues: 1. `unary_function` and `binary_function` not available in Cxx17 2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore. This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected. ## Changelog: [Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed Reviewed By: dmytrorykun Differential Revision: D49319256 fbshipit-source-id: cd93f0ad5c798cb9239e3454d0e9c38164ccc3e4
cipolleschi
force-pushed
the
export-D49319256
branch
from
4baddea
to
9a9b824
Compare
Summary: When testing Xcode 15, we realized that a few pods we do not control directly have the IPHONEOS_DEPLOYMENT_TARGET set to old versions of iOS. We can update that setting to silence the warning with Cocoapods and this is what this script does. Notice that bumping that setting generated other warning as some APIs have been deprecated. ## Changelog: [Internal] - Bump min IPHONEOS_DEPLOYMENT_TARGET for 3rd party pods Differential Revision: D49274837 fbshipit-source-id: ae0f2dfe05df2d38b081aebbb2481413a0a9fef1
Summary: Pull Request resolved: facebook#39474 When it comes to Xcode 15 RC, we are aware of two issues: 1. `unary_function` and `binary_function` not available in Cxx17 2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore. This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected. ## Changelog: [Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed Reviewed By: dmytrorykun Differential Revision: D49319256 fbshipit-source-id: 02d642645cfcfec968d3ebfb319ab635115f8b12
|
This pull request was exported from Phabricator. Differential Revision: D49319256 |
cipolleschi
force-pushed
the
export-D49319256
branch
from
9a9b824
to
7fb938c
Compare
|
This pull request has been merged in 0dbd621. |
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39474 When it comes to Xcode 15 RC, we are aware of two issues: 1. `unary_function` and `binary_function` not available in Cxx17 2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore. This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected. [Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed Reviewed By: dmytrorykun Differential Revision: D49319256 fbshipit-source-id: bb895f1e60db915db79684f71fa436ce80b42111
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39474 When it comes to Xcode 15 RC, we are aware of two issues: 1. `unary_function` and `binary_function` not available in Cxx17 2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore. This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected. [Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed Reviewed By: dmytrorykun Differential Revision: D49319256 fbshipit-source-id: bb895f1e60db915db79684f71fa436ce80b42111
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39474 When it comes to Xcode 15 RC, we are aware of two issues: 1. `unary_function` and `binary_function` not available in Cxx17 2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore. This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected. [Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed Reviewed By: dmytrorykun Differential Revision: D49319256 fbshipit-source-id: bb895f1e60db915db79684f71fa436ce80b42111
Titozzz
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #39474 When it comes to Xcode 15 RC, we are aware of two issues: 1. `unary_function` and `binary_function` not available in Cxx17 2. [Weak linking](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is not supported anymore. This change should fix both of the issues, adding the flags to allow for `unary_function`and `binary_function` to be called and adding the `-Wl -ld_classic` flag to `OTHER_LDFLAGS` in case Xcode 15 is detected. [Internal] - add the `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` and the `-Wl -ld_classic` flags to projects when needed Reviewed By: dmytrorykun Differential Revision: D49319256 fbshipit-source-id: bb895f1e60db915db79684f71fa436ce80b42111
This was referenced Sep 21, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Summary: Thanks for working through Xcode 15 compatibility issues! I reviewed the diff of the PR (#39474) that altered Xcode 15 settings for react-native release 0.72.5 and I noticed that - everything looked great (worth saying) - there was a grammatical error in another of the method names Trivial errors but, as long as I was in there, thought I'd submit a PR ## Changelog: [IOS] [FIXED] - fix grammar in Xcode 15 helper method name Pull Request resolved: #39658 Test Plan: CI should catch it of course, but in general I did a full grep for the name and changed everything / typical method name refactor Reviewed By: cortinico Differential Revision: D49641551 Pulled By: cipolleschi fbshipit-source-id: d77d33bbd6941f039dd30766e1308d5c4c4a6ca8
yayvery
pushed a commit
to discord/react-native
that referenced
this pull request
Oct 9, 2023
Summary: Thanks for working through Xcode 15 compatibility issues! I reviewed the diff of the PR (facebook#39474) that altered Xcode 15 settings for react-native release 0.72.5 and I noticed that - everything looked great (worth saying) - there was a grammatical error in another of the method names Trivial errors but, as long as I was in there, thought I'd submit a PR ## Changelog: [IOS] [FIXED] - fix grammar in Xcode 15 helper method name Pull Request resolved: facebook#39658 Test Plan: CI should catch it of course, but in general I did a full grep for the name and changed everything / typical method name refactor Reviewed By: cortinico Differential Revision: D49641551 Pulled By: cipolleschi fbshipit-source-id: d77d33bbd6941f039dd30766e1308d5c4c4a6ca8
This was referenced Oct 11, 2023
Merged
This was referenced Nov 1, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When it comes to Xcode 15 RC, we are aware of two issues:
unary_functionandbinary_functionnot available in Cxx17This change should fix both of the issues, adding the flags to allow for
unary_functionandbinary_functionto be called and adding the-Wl -ld_classicflag toOTHER_LDFLAGSin case Xcode 15 is detected.Changelog:
[Internal] - add the
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTIONand the-Wl -ld_classicflags to projects when neededDifferential Revision: D49319256