Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup BUCK setup for our JVM tests #39061

Closed
wants to merge 1 commit into from
+6 −7
Closed

Cleanup BUCK setup for our JVM tests #39061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...e/ReactAndroid/src/test/java/com/facebook/react/fabric/interop/InteropEventEmitterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ package com.facebook.react.fabric.interop
import com.facebook.react.bridge.JavaOnlyMap
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactContext
import com.facebook.testutils.fakes.FakeEventDispatcher
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Before
Expand All @@ -21,7 +22,7 @@ import org.robolectric.RuntimeEnvironment
@RunWith(RobolectricTestRunner::class)
class InteropEventEmitterTest {
lateinit var reactContext: ReactContext
lateinit var eventDispatcher: FakeEventDispatcher
private lateinit var eventDispatcher: FakeEventDispatcher

@Before
fun setup() {
Expand Down
8 changes: 3 additions & 5 deletions ...-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropConstantsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,19 @@ class ReactPropConstantsTest {
}

override fun createShadowNodeInstance(): ReactShadowNode<*>? {
Assertions.fail<Any>("This method should not be executed as a part of this test")
return null
error("This method should not be executed as a part of this test")
}

override fun createViewInstance(reactContext: ThemedReactContext): View {
Assertions.fail<Any>("This method should not be executed as a part of this test")
return View(reactContext)
error("This method should not be executed as a part of this test")
}

override fun getShadowNodeClass(): Class<out ReactShadowNode<*>> {
return ReactShadowNode::class.java
}

override fun updateExtraData(root: View, extraData: Any) {
Assertions.fail<Any>("This method should not be executed as a part of this test")
error("This method should not be executed as a part of this test")
}

@ReactProp(name = "boolProp") fun setBoolProp(v: View?, value: Boolean) {}
Expand Down
2 changes: 1 addition & 1 deletion ...act/fabric/interop/FakeEventDispatcher.kt → ...ok/testutils/fakes/FakeEventDispatcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

@file:Suppress("DEPRECATION") // Suppressing as RCTEventEmitter is part of the API
package com.facebook.react.fabric.interop
package com.facebook.testutils.fakes

import com.facebook.react.uimanager.events.BatchEventDispatchedListener
import com.facebook.react.uimanager.events.Event
Expand Down