Cleanup BUCK setup for our JVM tests #39061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48433432 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48433432 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39061 We're suppressing JVM tests using BUCK which is causing misalignment between which tests we run on Buck vs Gradle. Instead we should be using the Ignore annotation (which we already do) to decide which tests to skip, so that Buck can just pick all the Java/Kotlin file in this folder. Changelog: [Internal] [Changed] - Cleanup BUCK setup for our JVM tests Reviewed By: cipolleschi Differential Revision: D48433432 fbshipit-source-id: a4b80361c1a7b2012ad64257de8d0de36a076568
cortinico
force-pushed
the
export-D48433432
branch
from
cac14c6 to
01a5df8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48433432 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39061 We're suppressing JVM tests using BUCK which is causing misalignment between which tests we run on Buck vs Gradle. Instead we should be using the Ignore annotation (which we already do) to decide which tests to skip, so that Buck can just pick all the Java/Kotlin file in this folder. Changelog: [Internal] [Changed] - Cleanup BUCK setup for our JVM tests Reviewed By: cipolleschi Differential Revision: D48433432 fbshipit-source-id: d1f51b159c738502777675f4abd2cbd926aa13e0
cortinico
force-pushed
the
export-D48433432
branch
from
01a5df8 to
5b0ff06
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39061 We're suppressing JVM tests using BUCK which is causing misalignment between which tests we run on Buck vs Gradle. Instead we should be using the Ignore annotation (which we already do) to decide which tests to skip, so that Buck can just pick all the Java/Kotlin file in this folder. Changelog: [Internal] [Changed] - Cleanup BUCK setup for our JVM tests Reviewed By: cipolleschi Differential Revision: D48433432 fbshipit-source-id: d9ec15acb6cb3960e12b552f5156d516dac8f5fc
cortinico
force-pushed
the
export-D48433432
branch
from
5b0ff06 to
213fa96
Compare
Summary: Pull Request resolved: facebook#39061 We're suppressing JVM tests using BUCK which is causing misalignment between which tests we run on Buck vs Gradle. Instead we should be using the Ignore annotation (which we already do) to decide which tests to skip, so that Buck can just pick all the Java/Kotlin file in this folder. Changelog: [Internal] [Changed] - Cleanup BUCK setup for our JVM tests Reviewed By: cipolleschi Differential Revision: D48433432 fbshipit-source-id: c919d4988f424584d75160c67667352e48cce051
cortinico
force-pushed
the
export-D48433432
branch
from
213fa96 to
a6cadd5
Compare
Base commit: eb3d5a4 |
|
This pull request has been merged in ffa5742. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're suppressing JVM tests using BUCK which is causing misalignment between which tests we run on Buck vs Gradle.
Instead we should be using the Ignore annotation (which we already do) to decide which tests to skip, so that Buck can just pick all the Java/Kotlin file in this folder.
Changelog:
[Internal] [Changed] - Cleanup BUCK setup for our JVM tests
Reviewed By: cipolleschi
Differential Revision: D48433432