Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of YGConfigSetUseLegacyStretchBehaviour #37093

Closed
wants to merge 3 commits into from
Closed

Replace usages of YGConfigSetUseLegacyStretchBehaviour #37093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b7acc0
Set errata level in RN Paper, Litho, and Native Templates
NickGerleman Apr 27, 2023
9d4daa6
Deprecate Java YogaConfig.setUseLegacyStretchBehaviour()
NickGerleman Apr 27, 2023
5fa19e4
Replace usages of YGConfigSetUseLegacyStretchBehaviour (#37093)
NickGerleman Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/React/Views/RCTShadowView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ + (YGConfigRef)yogaConfig
dispatch_once(&onceToken, ^{
yogaConfig = YGConfigNew();
YGConfigSetPointScaleFactor(yogaConfig, RCTScreenScale());
YGConfigSetUseLegacyStretchBehaviour(yogaConfig, true);
YGConfigSetErrata(yogaConfig, YGErrataAll);
});
return yogaConfig;
}
Expand Down
3 changes: 2 additions & 1 deletion ...tive/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import com.facebook.yoga.YogaConfig;
import com.facebook.yoga.YogaConfigFactory;
import com.facebook.yoga.YogaErrata;

public class ReactYogaConfigProvider {

Expand All @@ -18,7 +19,7 @@ public static YogaConfig get() {
if (YOGA_CONFIG == null) {
YOGA_CONFIG = YogaConfigFactory.create();
YOGA_CONFIG.setPointScaleFactor(0f);
YOGA_CONFIG.setUseLegacyStretchBehaviour(true);
YOGA_CONFIG.setErrata(YogaErrata.ALL);
}
return YOGA_CONFIG;
}
Expand Down
6 changes: 6 additions & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ public abstract class YogaConfig {
* Yoga previously had an error where containers would take the maximum space possible instead of the minimum
* like they are supposed to. In practice this resulted in implicit behaviour similar to align-self: stretch;
* Because this was such a long-standing bug we must allow legacy users to switch back to this behaviour.
*
* @deprecated "setUseLegacyStretchBehaviour" will be removed in the next release. Usage should be replaced with
* "setErrata(YogaErrata.ALL)" to opt out of all future breaking conformance fixes, or
* "setErrata(YogaErrata.STRETCH_FLEX_BASIS)" to opt out of the specific conformance fix previously disabled by
* "UseLegacyStretchBehaviour".
*/
@Deprecated
public abstract void setUseLegacyStretchBehaviour(boolean useLegacyStretchBehaviour);

public abstract void setErrata(YogaErrata errata);
Expand Down
2 changes: 1 addition & 1 deletion ...ages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ YogaLayoutableShadowNode &YogaLayoutableShadowNode::shadowNodeFromContext(
YGConfig &YogaLayoutableShadowNode::initializeYogaConfig(YGConfig &config) {
YGConfigSetCloneNodeFunc(
&config, YogaLayoutableShadowNode::yogaNodeCloneCallbackConnector);
YGConfigSetUseLegacyStretchBehaviour(&config, true);
YGConfigSetErrata(&config, YGErrataAll);
#ifdef RN_DEBUG_YOGA_LOGGER
YGConfigSetPrintTreeFlag(&config, true);
#endif
Expand Down