New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of YGConfigSetUseLegacyStretchBehaviour #37093

Closed

NickGerleman wants to merge 3 commits into facebook:main from NickGerleman:export-D45300631

Contributor

NickGerleman commented Apr 26, 2023

Summary:
This replaces product usages of YGConfigSetUseLegacyStretchBehaviour with instead setting YGErrataAll, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying YGErrataClassic, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Differential Revision: D45300631

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Apr 26, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

analysis-bot commented Apr 26, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,499,710	+239
android	hermes	armeabi-v7a	7,833,554	+219
android	hermes	x86	8,977,657	+238
android	hermes	x86_64	8,834,477	+229
android	jsc	arm64-v8a	9,064,270	+339
android	jsc	armeabi-v7a	8,275,566	+318
android	jsc	x86	9,113,565	+341
android	jsc	x86_64	9,374,032	+334

Base commit: b3478cb
Branch: main

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

4d8993e

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 50ae18fe20a30c3d607caba15b080cafad0ecc46

NickGerleman force-pushed the export-D45300631 branch from c5027e1 to 4d8993e Compare

April 27, 2023 04:52

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

1 similar comment

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

957b5b5

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 6828d6bf537591e1811d85122f162f9497771c4d

NickGerleman force-pushed the export-D45300631 branch from 4d8993e to 957b5b5 Compare

April 27, 2023 04:59

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

a3fef74

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: f6289229414b7e10f42918cb557a421a82b3c02d

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman force-pushed the export-D45300631 branch from 957b5b5 to a3fef74 Compare

April 27, 2023 13:31

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

b336921

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: a410ae9b22b463755e6d454f7fee80abd8b91f5e

NickGerleman force-pushed the export-D45300631 branch from a3fef74 to b336921 Compare

April 27, 2023 13:58

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

863596b

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 9178f9e175b6abeec7770cca0371230ce8f07b49

NickGerleman force-pushed the export-D45300631 branch from b336921 to 863596b Compare

April 27, 2023 14:05

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

1 similar comment

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

9ca493b

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 054be9d2cf52a9848ccbaf0e325519c77600e844

NickGerleman force-pushed the export-D45300631 branch from 863596b to 9ca493b Compare

April 27, 2023 14:11

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

e1ac479

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 401ad047ad2a8466acb0f799844f7f32d033ffc0

NickGerleman force-pushed the export-D45300631 branch from 9ca493b to e1ac479 Compare

April 27, 2023 14:17

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

ffcd273

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 6c2ec36336764e5e7fe3cce55f1d32953afdac92

NickGerleman force-pushed the export-D45300631 branch from e1ac479 to ffcd273 Compare

April 27, 2023 14:26

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

1 similar comment

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

de0ffc9

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: cff1981e63460ac7149c67d2a4d93e412393eea1

NickGerleman force-pushed the export-D45300631 branch from db508e1 to de0ffc9 Compare

April 27, 2023 15:07

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

9ef530c

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 43e6504a311bd14a90691635524e50f787b19f9b

NickGerleman force-pushed the export-D45300631 branch from de0ffc9 to 9ef530c Compare

April 27, 2023 15:13

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

e015f16

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 7dec964c9e09c9ebcb59c5971af2fb8a139fe836

NickGerleman force-pushed the export-D45300631 branch from 9ef530c to e015f16 Compare

April 27, 2023 15:29

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

1 similar comment

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

8d0dede

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 77069bfdbd3a2c516be920aaae5a45a5b063ea08

NickGerleman force-pushed the export-D45300631 branch from e015f16 to 8d0dede Compare

April 27, 2023 16:44

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

14668e8

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 4640f033b52f14db3f26dc682799a4c2c3235132

NickGerleman force-pushed the export-D45300631 branch from 8d0dede to 14668e8 Compare

April 27, 2023 16:52

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

9213f88

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: dbe8c82b3de677b9788878dc2b4fa2aaccabe156

NickGerleman force-pushed the export-D45300631 branch from 14668e8 to 9213f88 Compare

April 27, 2023 16:57

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman and others added 3 commits

April 27, 2023 12:29


          Set errata level in RN Paper, Litho, and Native Templates

5b7acc0

Summary:
This searches fbsource for the following strings corresponding to node or config creation using Yoga Java bindings.
1. `YogaNodeFactory.create`
2. `YogaConfigFactory.create`

Apart from benchmarks/tests, thie leaves RN Paper, Litho and Native Templates. These are opted into compatibility with current Yoga behavior, using either `YogaErrata.CLASSIC`, or `YogaErrata.ALL` where `UseLegacyStretchBehaviour` is currently set.

Differential Revision: https://internalfb.com/D45299721

fbshipit-source-id: 1814cb375ab0a51e9b0bbb58bd35aac4ce8e33c6


          Deprecate Java YogaConfig.setUseLegacyStretchBehaviour()

9d4daa6

Summary: Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing.

Differential Revision: D45300343

fbshipit-source-id: 11980ef895bc2bc8073fa6c10df4ccd11eb71c91


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

5fa19e4

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 97b5f4a70f77a590d77248f2a9d2b8fa6633004e

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request was exported from Phabricator. Differential Revision: D45300631

NickGerleman force-pushed the export-D45300631 branch from 9213f88 to 5fa19e4 Compare

April 27, 2023 19:31

facebook-github-bot closed this in

b0cf746

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Apr 27, 2023

This pull request has been merged in b0cf746.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

be6194d

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 9f94bdbbe7eda091adac016231083b2486c583d9

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request


          Replace usages of YGConfigSetUseLegacyStretchBehaviour (facebook#37093)

4b2f492

Summary:
Pull Request resolved: facebook#37093

This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility.

We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D45300631

fbshipit-source-id: 9f94bdbbe7eda091adac016231083b2486c583d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner