Deprecate EventBeatManager constructor #36905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There are some unused methods of view recycling in Android changelog: [internal] internal Differential Revision: D44677790 fbshipit-source-id: 5588bfdd12f7ee1df2761a24af6331e64154a5b8
Summary: Delete unused method exposed in BaseJavaModule changelog: [Android]Breaking] Delete hasConstants() method from BaseJavaModule Differential Revision: D44678688 fbshipit-source-id: c687b903dcde61014bc10a8e5f7bb1665498b2c0
Summary: In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 changelog: [Android][Breaking] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Differential Revision: D44682968 fbshipit-source-id: 9a856b05581838bb9c937e6a0773e9b5e2e1955e
Summary: In this diff I'm deprecating EventBeatManager constructor that receives a Context as a parameter. changelog: [Android][Deprecated] deprecating EventBeatManager constructor that receives a Context as a parameter. Reviewed By: fkgozali Differential Revision: D44759827 fbshipit-source-id: 60027e3a30057fa82c33f8f1feb090c8ad0f3e8c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44759827 |
Base commit: d50934a |
|
This pull request has been merged in 363224e. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36905 In this diff I'm deprecating EventBeatManager constructor that receives a Context as a parameter. bypass-github-export-checks changelog: [Android][Deprecated] deprecating EventBeatManager constructor that receives a Context as a parameter. Reviewed By: fkgozali Differential Revision: D44759827 fbshipit-source-id: cb117c26af0a43fe245f8778a55dfbea756b3ce6
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36905 In this diff I'm deprecating EventBeatManager constructor that receives a Context as a parameter. bypass-github-export-checks changelog: [Android][Deprecated] deprecating EventBeatManager constructor that receives a Context as a parameter. Reviewed By: fkgozali Differential Revision: D44759827 fbshipit-source-id: cb117c26af0a43fe245f8778a55dfbea756b3ce6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm deprecating EventBeatManager constructor that receives a Context as a parameter.
changelog: [Android][Deprecated] deprecating EventBeatManager constructor that receives a Context as a parameter.
Reviewed By: fkgozali
Differential Revision: D44759827