Deprecate EventBeatManager constructor (facebook#36905)

Summary: Pull Request resolved: facebook#36905 In this diff I'm deprecating EventBeatManager constructor that receives a Context as a parameter. bypass-github-export-checks changelog: [Android][Deprecated] deprecating EventBeatManager constructor that receives a Context as a parameter. Reviewed By: fkgozali Differential Revision: D44759827 fbshipit-source-id: cb117c26af0a43fe245f8778a55dfbea756b3ce6
OlimpiaZurek · May 22, 2023 · 426b3a7 · 426b3a7
1 parent 6495b57
commit 426b3a7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/.../react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactInstance.java b/.../react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactInstance.java
@@ -221,7 +221,7 @@ public Collection<String> getViewManagerNames() {
               }
             });
 
-    EventBeatManager eventBeatManager = new EventBeatManager(mBridgelessReactContext);
+    EventBeatManager eventBeatManager = new EventBeatManager();
     mFabricUIManager =
         new FabricUIManager(mBridgelessReactContext, viewManagerRegistry, eventBeatManager);
 

diff --git a/...-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java b/...-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java
@@ -36,7 +36,7 @@ public FabricJSIModuleProvider(
   @Override
   public UIManager get() {
     Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.get");
-    final EventBeatManager eventBeatManager = new EventBeatManager(mReactApplicationContext);
+    final EventBeatManager eventBeatManager = new EventBeatManager();
     final FabricUIManager uiManager = createUIManager(eventBeatManager);
 
     Systrace.beginSection(

diff --git a/...-native/ReactAndroid/src/main/java/com/facebook/react/fabric/events/EventBeatManager.java b/...-native/ReactAndroid/src/main/java/com/facebook/react/fabric/events/EventBeatManager.java
@@ -19,22 +19,25 @@
  * Class that acts as a proxy between the list of EventBeats registered in C++ and the Android side.
  */
 @SuppressLint("MissingNativeLoadLibrary")
-public class EventBeatManager implements BatchEventDispatchedListener {
+public final class EventBeatManager implements BatchEventDispatchedListener {
 
   static {
     FabricSoLoader.staticInit();
   }
 
   @DoNotStrip private final HybridData mHybridData;
-  private final ReactApplicationContext mReactApplicationContext;
 
   private static native HybridData initHybrid();
 
   private native void tick();
 
+  @Deprecated(forRemoval = true, since = "Deprecated on v0.72.0 Use EventBeatManager() instead")
   public EventBeatManager(@NonNull ReactApplicationContext reactApplicationContext) {
+    this();
+  }
+
+  public EventBeatManager() {
     mHybridData = initHybrid();
-    mReactApplicationContext = reactApplicationContext;
   }
 
   @Override