Fix: Remove installation of Python 3 in CI for Windows #36596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: da027dd |
|
@cipolleschi merged this pull request in 0443c2a. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: We used to have to install python 3 on windows. Starting from yesterday (22/03/2023) the `build_hermesc_window` job started failing because Python3 is already installed on the default machine. ## Changelog: [INTERNAL] [FIXED] - Skip installing python 3 on Windows as it's already there. Pull Request resolved: facebook#36596 Test Plan: CircleCI must be green Reviewed By: hoxyq Differential Revision: D44330936 Pulled By: cipolleschi fbshipit-source-id: b58190f707be309d919aceb80af717046c9476b4
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: We used to have to install python 3 on windows. Starting from yesterday (22/03/2023) the `build_hermesc_window` job started failing because Python3 is already installed on the default machine. ## Changelog: [INTERNAL] [FIXED] - Skip installing python 3 on Windows as it's already there. Pull Request resolved: facebook#36596 Test Plan: CircleCI must be green Reviewed By: hoxyq Differential Revision: D44330936 Pulled By: cipolleschi fbshipit-source-id: b58190f707be309d919aceb80af717046c9476b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We used to have to install python 3 on windows. Starting from yesterday (22/03/2023) the
build_hermesc_windowjob started failing because Python3 is already installed on the default machine.Changelog:
[INTERNAL] [FIXED] - Skip installing python 3 on Windows as it's already there.
Test Plan
CircleCI must be green