Skip to content

Commit

Permalink
Fix: Remove installation of Python 3 in CI for Windows (#36596)
Browse files Browse the repository at this point in the history
Summary:
We used to have to install python 3 on windows. Starting from yesterday (22/03/2023) the `build_hermesc_window` job started failing because Python3 is already installed on the default machine.

## Changelog:

[INTERNAL] [FIXED] - Skip installing python 3 on Windows as it's already there.

Pull Request resolved: #36596

Test Plan: CircleCI must be green

Reviewed By: hoxyq

Differential Revision: D44330936

Pulled By: cipolleschi

fbshipit-source-id: b58190f707be309d919aceb80af717046c9476b4
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Mar 23, 2023
1 parent dd6d57e commit 0443c2a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1368,8 +1368,6 @@ jobs:
if (-not(Test-Path -Path $Env:HERMES_WS_DIR\win64-bin\hermesc.exe)) {
choco install --no-progress cmake --version 3.14.7
if (-not $?) { throw "Failed to install CMake" }
choco install --no-progress python3
if (-not $?) { throw "Failed to install Python" }
cd $Env:HERMES_WS_DIR\icu
# If Invoke-WebRequest shows a progress bar, it will fail with
Expand Down

0 comments on commit 0443c2a

Please sign in to comment.