Generate Custom Native State #34796
Closed
Generate Custom Native State #34796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: D39816763 fbshipit-source-id: 7793b0cce27251fcbff57a452f132b587d40bbfd
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39816763 |
react-native-bot
added
the
Type: Enhancement
Base commit: f85e2ec |
Base commit: f85e2ec |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: 0f5cf583f26c8ad63ce98e1cb97b92d14190f1cd
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: 2753722abd0272140c03fc4b8e8313b47649a23a
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: 26b799fcd2265d1c3c7a00fa34586ce010064e66
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: 3f0bfde785b3846c56418d93d7131c27bed505f8
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: 612f13ef3318d1c35fe7d276861c6d9f19e4f5bd
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: c369d4965ce092d081b6b69947f32d01a7bcfeb0
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Oct 9, 2022
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: f9ad9811a918d692b6a94766b52a9810549cdcb7
|
This pull request was successfully merged by @cipolleschi in 7490ad4. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Reviewed By: cortinico Differential Revision: D39816763 fbshipit-source-id: 42d1aa9a6df23145f4a46ae8ccfb43d81fa651fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces the generation of custom native states using basic types as we do with the Props.
To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types.
This diff adds and updates the tests for the State.
Changelog
[General][Added] - Generate custom Native State
Differential Revision: D39816763