Generate Custom Native State (facebook#34796)

Summary: Pull Request resolved: facebook#34796 This diff introduces the generation of custom native states using basic types as we do with the Props. To make it work, the custom types are already writte in the Props.h file, therefore the State.h file must import that other file to have access to the required types. This diff adds and updates the tests for the State. ## Changelog [General][Added] - Generate custom Native State Differential Revision: https://internalfb.com/D39816763 fbshipit-source-id: 2753722abd0272140c03fc4b8e8313b47649a23a
cipolleschi · Oct 9, 2022 · 9f4f226 · 9f4f226
1 parent 7227bde
commit 9f4f226
Show file tree

Hide file tree

Showing 22 changed files with 8,243 additions and 310 deletions.
diff --git a/packages/react-native-codegen/src/generators/components/ComponentsGeneratorUtils.js b/packages/react-native-codegen/src/generators/components/ComponentsGeneratorUtils.js
@@ -0,0 +1,158 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict
+ * @format
+ */
+
+'use strict';
+
+import type {
+  NamedShape,
+  PropTypeAnnotation,
+  StateTypeAnnotation,
+} from '../../CodegenSchema';
+
+import type {
+  StringTypeAnnotation,
+  ReservedPropTypeAnnotation,
+  ObjectTypeAnnotation,
+  Int32TypeAnnotation,
+  FloatTypeAnnotation,
+  DoubleTypeAnnotation,
+  BooleanTypeAnnotation,
+} from '../../CodegenSchema';
+
+const {
+  convertDefaultTypeToString,
+  getCppTypeForAnnotation,
+  getEnumMaskName,
+  getEnumName,
+  generateStructName,
+} = require('./CppHelpers.js');
+
+function getNativeTypeFromAnnotation(
+  componentName: string,
+  prop:
+    | NamedShape<PropTypeAnnotation>
+    | NamedShape<StateTypeAnnotation>
+    | {
+        name: string,
+        typeAnnotation:
+          | $FlowFixMe
+          | DoubleTypeAnnotation
+          | FloatTypeAnnotation
+          | BooleanTypeAnnotation
+          | Int32TypeAnnotation
+          | StringTypeAnnotation
+          | ObjectTypeAnnotation<PropTypeAnnotation>
+          | ReservedPropTypeAnnotation
+          | {
+              +default: string,
+              +options: $ReadOnlyArray<string>,
+              +type: 'StringEnumTypeAnnotation',
+            }
+          | {
+              +elementType: ObjectTypeAnnotation<PropTypeAnnotation>,
+              +type: 'ArrayTypeAnnotation',
+            },
+      },
+  nameParts: $ReadOnlyArray<string>,
+): string {
+  const typeAnnotation = prop.typeAnnotation;
+
+  switch (typeAnnotation.type) {
+    case 'BooleanTypeAnnotation':
+    case 'StringTypeAnnotation':
+    case 'Int32TypeAnnotation':
+    case 'DoubleTypeAnnotation':
+    case 'FloatTypeAnnotation':
+      return getCppTypeForAnnotation(typeAnnotation.type);
+    case 'ReservedPropTypeAnnotation':
+      switch (typeAnnotation.name) {
+        case 'ColorPrimitive':
+          return 'SharedColor';
+        case 'ImageSourcePrimitive':
+          return 'ImageSource';
+        case 'PointPrimitive':
+          return 'Point';
+        case 'EdgeInsetsPrimitive':
+          return 'EdgeInsets';
+        default:
+          (typeAnnotation.name: empty);
+          throw new Error('Received unknown ReservedPropTypeAnnotation');
+      }
+    case 'ArrayTypeAnnotation': {
+      const arrayType = typeAnnotation.elementType.type;
+      if (arrayType === 'ArrayTypeAnnotation') {
+        return `std::vector<${getNativeTypeFromAnnotation(
+          componentName,
+          {typeAnnotation: typeAnnotation.elementType, name: ''},
+          nameParts.concat([prop.name]),
+        )}>`;
+      }
+      if (arrayType === 'ObjectTypeAnnotation') {
+        const structName = generateStructName(
+          componentName,
+          nameParts.concat([prop.name]),
+        );
+        return `std::vector<${structName}>`;
+      }
+      if (arrayType === 'StringEnumTypeAnnotation') {
+        const enumName = getEnumName(componentName, prop.name);
+        return getEnumMaskName(enumName);
+      }
+      const itemAnnotation = getNativeTypeFromAnnotation(
+        componentName,
+        {
+          typeAnnotation: typeAnnotation.elementType,
+          name: componentName,
+        },
+        nameParts.concat([prop.name]),
+      );
+      return `std::vector<${itemAnnotation}>`;
+    }
+    case 'ObjectTypeAnnotation': {
+      return generateStructName(componentName, nameParts.concat([prop.name]));
+    }
+    case 'StringEnumTypeAnnotation':
+      return getEnumName(componentName, prop.name);
+    case 'Int32EnumTypeAnnotation':
+      return getEnumName(componentName, prop.name);
+    default:
+      (typeAnnotation: empty);
+      throw new Error(
+        `Received invalid typeAnnotation for ${componentName} prop ${prop.name}, received ${typeAnnotation.type}`,
+      );
+  }
+}
+
+function getStateConstituents(
+  componentName: string,
+  stateShape: NamedShape<StateTypeAnnotation>,
+): {
+  name: string,
+  varName: string,
+  type: string,
+  defaultValue: $FlowFixMe,
+} {
+  const name = stateShape.name;
+  const varName = `${name}_`;
+  const type = getNativeTypeFromAnnotation(componentName, stateShape, []);
+  const defaultValue = convertDefaultTypeToString(componentName, stateShape);
+
+  return {
+    name,
+    varName,
+    type,
+    defaultValue,
+  };
+}
+
+module.exports = {
+  getNativeTypeFromAnnotation,
+  getStateConstituents,
+};
diff --git a/packages/react-native-codegen/src/generators/components/GeneratePropsH.js b/packages/react-native-codegen/src/generators/components/GeneratePropsH.js
@@ -9,20 +9,12 @@
  */
 
 'use strict';
-import type {
-  StringTypeAnnotation,
-  ReservedPropTypeAnnotation,
-  ObjectTypeAnnotation,
-  Int32TypeAnnotation,
-  FloatTypeAnnotation,
-  DoubleTypeAnnotation,
-  ComponentShape,
-  BooleanTypeAnnotation,
-} from '../../CodegenSchema';
+import type {ComponentShape} from '../../CodegenSchema';
+
+const {getNativeTypeFromAnnotation} = require('./ComponentsGeneratorUtils.js');
 
 const {
   convertDefaultTypeToString,
-  getCppTypeForAnnotation,
   getEnumMaskName,
   getEnumName,
   toSafeCppString,
@@ -294,101 +286,6 @@ function getClassExtendString(component: ComponentShape): string {
   return extendString;
 }
 
-function getNativeTypeFromAnnotation(
-  componentName: string,
-  prop:
-    | NamedShape<PropTypeAnnotation>
-    | {
-        name: string,
-        typeAnnotation:
-          | $FlowFixMe
-          | DoubleTypeAnnotation
-          | FloatTypeAnnotation
-          | BooleanTypeAnnotation
-          | Int32TypeAnnotation
-          | StringTypeAnnotation
-          | ObjectTypeAnnotation<PropTypeAnnotation>
-          | ReservedPropTypeAnnotation
-          | {
-              +default: string,
-              +options: $ReadOnlyArray<string>,
-              +type: 'StringEnumTypeAnnotation',
-            }
-          | {
-              +elementType: ObjectTypeAnnotation<PropTypeAnnotation>,
-              +type: 'ArrayTypeAnnotation',
-            },
-      },
-  nameParts: $ReadOnlyArray<string>,
-): string {
-  const typeAnnotation = prop.typeAnnotation;
-
-  switch (typeAnnotation.type) {
-    case 'BooleanTypeAnnotation':
-    case 'StringTypeAnnotation':
-    case 'Int32TypeAnnotation':
-    case 'DoubleTypeAnnotation':
-    case 'FloatTypeAnnotation':
-      return getCppTypeForAnnotation(typeAnnotation.type);
-    case 'ReservedPropTypeAnnotation':
-      switch (typeAnnotation.name) {
-        case 'ColorPrimitive':
-          return 'SharedColor';
-        case 'ImageSourcePrimitive':
-          return 'ImageSource';
-        case 'PointPrimitive':
-          return 'Point';
-        case 'EdgeInsetsPrimitive':
-          return 'EdgeInsets';
-        default:
-          (typeAnnotation.name: empty);
-          throw new Error('Received unknown ReservedPropTypeAnnotation');
-      }
-    case 'ArrayTypeAnnotation': {
-      const arrayType = typeAnnotation.elementType.type;
-      if (arrayType === 'ArrayTypeAnnotation') {
-        return `std::vector<${getNativeTypeFromAnnotation(
-          componentName,
-          {typeAnnotation: typeAnnotation.elementType, name: ''},
-          nameParts.concat([prop.name]),
-        )}>`;
-      }
-      if (arrayType === 'ObjectTypeAnnotation') {
-        const structName = generateStructName(
-          componentName,
-          nameParts.concat([prop.name]),
-        );
-        return `std::vector<${structName}>`;
-      }
-      if (arrayType === 'StringEnumTypeAnnotation') {
-        const enumName = getEnumName(componentName, prop.name);
-        return getEnumMaskName(enumName);
-      }
-      const itemAnnotation = getNativeTypeFromAnnotation(
-        componentName,
-        {
-          typeAnnotation: typeAnnotation.elementType,
-          name: componentName,
-        },
-        nameParts.concat([prop.name]),
-      );
-      return `std::vector<${itemAnnotation}>`;
-    }
-    case 'ObjectTypeAnnotation': {
-      return generateStructName(componentName, nameParts.concat([prop.name]));
-    }
-    case 'StringEnumTypeAnnotation':
-      return getEnumName(componentName, prop.name);
-    case 'Int32EnumTypeAnnotation':
-      return getEnumName(componentName, prop.name);
-    default:
-      (typeAnnotation: empty);
-      throw new Error(
-        `Received invalid typeAnnotation for ${componentName} prop ${prop.name}, received ${typeAnnotation.type}`,
-      );
-  }
-}
-
 function convertValueToEnumOption(value: string): string {
   return toSafeCppString(value);
 }

diff --git a/packages/react-native-codegen/src/generators/components/GenerateStateCpp.js b/packages/react-native-codegen/src/generators/components/GenerateStateCpp.js
@@ -10,17 +10,23 @@
 
 'use strict';
 
-import type {SchemaType} from '../../CodegenSchema';
+import type {
+  NamedShape,
+  SchemaType,
+  StateTypeAnnotation,
+} from '../../CodegenSchema';
+const {capitalize} = require('../Utils.js');
+const {getStateConstituents} = require('./ComponentsGeneratorUtils.js');
 
 // File path -> contents
 type FilesOutput = Map<string, string>;
 
 const FileTemplate = ({
   libraryName,
-  stateClasses,
+  stateGetters,
 }: {
   libraryName: string,
-  stateClasses: string,
+  stateGetters: string,
 }) => `
 /**
  * This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
@@ -35,13 +41,32 @@ const FileTemplate = ({
 namespace facebook {
 namespace react {
 
-${stateClasses}
+${stateGetters}
 
 } // namespace react
 } // namespace facebook
 `;
 
-const StateTemplate = ({stateName}: {stateName: string}) => '';
+function generateStrings(
+  componentName: string,
+  state: $ReadOnlyArray<NamedShape<StateTypeAnnotation>>,
+) {
+  let getters = '';
+  state.forEach(stateShape => {
+    const {name, varName, type} = getStateConstituents(
+      componentName,
+      stateShape,
+    );
+
+    getters += `
+${type} ${componentName}::get${capitalize(name)}() const {
+  return ${varName};
+}
+`;
+  });
+
+  return getters.trim();
+}
 
 module.exports = {
   generate(
@@ -52,7 +77,7 @@ module.exports = {
   ): FilesOutput {
     const fileName = 'States.cpp';
 
-    const stateClasses = Object.keys(schema.modules)
+    const stateGetters = Object.keys(schema.modules)
       .map(moduleName => {
         const module = schema.modules[moduleName];
         if (module.type !== 'Component') {
@@ -67,12 +92,16 @@ module.exports = {
 
         return Object.keys(components)
           .map(componentName => {
-            if (components[componentName].interfaceOnly === true) {
+            const component = components[componentName];
+            if (component.interfaceOnly === true) {
               return null;
             }
-            return StateTemplate({
-              stateName: `${componentName}State`,
-            });
+
+            const state = component.state;
+            if (!state) {
+              return '';
+            }
+            return generateStrings(componentName, state);
           })
           .filter(Boolean)
           .join('\n');
@@ -82,7 +111,7 @@ module.exports = {
 
     const replacedTemplate = FileTemplate({
       libraryName,
-      stateClasses,
+      stateGetters,
     });
 
     return new Map([[fileName, replacedTemplate]]);