Simplify the template for New Architecture using the .defaults package #34445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38820111 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D38820111 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 18, 2022
facebook#34445) Summary: Pull Request resolved: facebook#34445 This commit simplifies the new app template by encapsulating a lot of configuration by using the `DefaultReactNativeHost` from the .defaults package. This should work for most of the users while still allowing advanced use cases by using the good old ReactNativeHost. Changelog: [Android] [Changed] - Simplify the template for New Architecture using the .defaults package Differential Revision: D38820111 fbshipit-source-id: d8979198a538cdbd34e853e1fe1b83941d3549cb
cortinico
force-pushed
the
export-D38820111
branch
from
9b098eb to
adf40e4
Compare
Base commit: 4eec473 |
|
This pull request was exported from Phabricator. Differential Revision: D38820111 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 18, 2022
facebook#34445) Summary: Pull Request resolved: facebook#34445 This commit simplifies the new app template by encapsulating a lot of configuration by using the `DefaultReactNativeHost` from the .defaults package. This should work for most of the users while still allowing advanced use cases by using the good old ReactNativeHost. Changelog: [Android] [Changed] - Simplify the template for New Architecture using the .defaults package Reviewed By: cipolleschi Differential Revision: D38820111 fbshipit-source-id: 9853140e9d8c15606a3856aa60523c8ac6160a3d
cortinico
force-pushed
the
export-D38820111
branch
from
adf40e4 to
e8c6b4b
Compare
facebook#34445) Summary: Pull Request resolved: facebook#34445 This commit simplifies the new app template by encapsulating a lot of configuration by using the `DefaultReactNativeHost` from the .defaults package. This should work for most of the users while still allowing advanced use cases by using the good old ReactNativeHost. Changelog: [Android] [Changed] - Simplify the template for New Architecture using the .defaults package Reviewed By: cipolleschi Differential Revision: D38820111 fbshipit-source-id: 64a9e9576e53347e1b021c473f7bfa755521a1a6
|
This pull request was exported from Phabricator. Differential Revision: D38820111 |
cortinico
force-pushed
the
export-D38820111
branch
from
e8c6b4b to
a3bef0a
Compare
|
This pull request was successfully merged by @cortinico in 33bd2f6. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit simplifies the new app template by encapsulating a lot of configuration
by using the
DefaultReactNativeHostfrom the .defaults package.This should work for most of the users while still allowing advanced use cases
by using the good old ReactNativeHost.
Changelog:
[Android] [Changed] - Simplify the template for New Architecture using the .defaults package
Differential Revision: D38820111