-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify the template for New Architecture using the .defaults package (
#34445) Summary: Pull Request resolved: #34445 This commit simplifies the new app template by encapsulating a lot of configuration by using the `DefaultReactNativeHost` from the .defaults package. This should work for most of the users while still allowing advanced use cases by using the good old ReactNativeHost. Changelog: [Android] [Changed] - Simplify the template for New Architecture using the .defaults package Reviewed By: cipolleschi Differential Revision: D38820111 fbshipit-source-id: 4e9529a92e1681610e3a1a89fdf82e6d10a18809
- Loading branch information
1 parent
ae8d01e
commit 33bd2f6
Showing
9 changed files
with
33 additions
and
230 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 0 additions & 116 deletions
116
...roid/app/src/main/java/com/helloworld/newarchitecture/MainApplicationReactNativeHost.java
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
...d/app/src/main/java/com/helloworld/newarchitecture/components/MainComponentsRegistry.java
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
...ava/com/helloworld/newarchitecture/modules/MainApplicationTurboModuleManagerDelegate.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
cmake_minimum_required(VERSION 3.13) | ||
|
||
# Define the library name here. | ||
project(helloworld_appmodules) | ||
project(${TARGET_NAME}) | ||
|
||
# This file includes all the necessary to let you build your application with the New Architecture. | ||
include(${REACT_ANDROID_DIR}/cmake-utils/ReactNative-application.cmake) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters