Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run ESLint in Danger #34305

Closed
wants to merge 3 commits into from
Closed

[CI] Run ESLint in Danger #34305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6369ed0
test: linters
Jul 29, 2022
760c148
test: linters
Jul 29, 2022
addee80
feat: enable eslint in danger
Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/danger_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: yarn install
working-directory: .
- run: yarn install
working-directory: bots
- name: Danger
Expand Down
5 changes: 4 additions & 1 deletion bots/dangerfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@

'use strict';

const {danger, fail, message, warn} = require('danger');
const {danger, fail, /*message,*/ warn} = require('danger');
const includes = require('lodash.includes');
const eslint = require('@seadub/danger-plugin-eslint');

const isFromPhabricator =
danger.github.pr.body &&
Expand Down Expand Up @@ -112,3 +113,5 @@ if (isMergeRefStable) {
},
);
}

eslint.default();
1 change: 1 addition & 0 deletions bots/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"danger": "node ./node_modules/.bin/danger"
},
"devDependencies": {
"@seadub/danger-plugin-eslint": "^3.0.2",
"danger": "^11.0.2",
"lodash.includes": "^4.3.0",
"minimatch": "^3.0.4"
Expand Down
5 changes: 5 additions & 0 deletions bots/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,11 @@
resolved "https://registry.yarnpkg.com/@protobufjs/utf8/-/utf8-1.1.0.tgz#a777360b5b39a1a2e5106f8e858f2fd2d060c570"
integrity sha1-p3c2C1s5oaLlEG+OhY8v0tBgxXA=

"@seadub/danger-plugin-eslint@^3.0.2":
version "3.0.2"
resolved "https://registry.yarnpkg.com/@seadub/danger-plugin-eslint/-/danger-plugin-eslint-3.0.2.tgz#9a51d9f1a103a274264c30212234001de0b417c1"
integrity sha512-W+efX4mP04A8wMuLV0nV+iOj892Vrbyik+FyDZcGgpzkJFXX0UfDhOPZ0FonbSV0xM47DI5a8go88U/pBdGM2A==

"@types/long@^4.0.1":
version "4.0.1"
resolved "https://registry.yarnpkg.com/@types/long/-/long-4.0.1.tgz#459c65fa1867dafe6a8f322c4c51695663cc55e9"
Expand Down