[CI] Run ESLint in Danger #34305
Closed
[CI] Run ESLint in Danger #34305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 9797388 |
Base commit: a53512f |
cipolleschi
force-pushed
the
feat/add-meta-linters
branch
25 times, most recently
from
1ce6a69 to
9706373
Compare
cipolleschi
force-pushed
the
feat/add-meta-linters
branch
16 times, most recently
from
9f8e1a8 to
a12d3f0
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
feat/add-meta-linters
branch
3 times, most recently
from
5c0f7c0 to
7f32fae
Compare
cipolleschi
force-pushed
the
feat/add-meta-linters
branch
from
7f32fae to
addee80
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cipolleschi in 1bba590. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: This PR runs eslint in PR using Danger. ## Changelog [General] [Changed] - Run ESLint in CI Pull Request resolved: facebook#34305 Test Plan: 1. Add a JS lint error in the package/react-native-codegen package. 2. Observe the CI task post a message with the errors 3. Fix the errors 4. Observe the CI task report completion with no errors Reviewed By: cortinico Differential Revision: D38315268 Pulled By: cipolleschi fbshipit-source-id: 9984402ee427dd62d47dd716f73c030e6d0f7b5e
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: This PR runs eslint in PR using Danger. ## Changelog [General] [Changed] - Run ESLint in CI Pull Request resolved: facebook#34305 Test Plan: 1. Add a JS lint error in the package/react-native-codegen package. 2. Observe the CI task post a message with the errors 3. Fix the errors 4. Observe the CI task report completion with no errors Reviewed By: cortinico Differential Revision: D38315268 Pulled By: cipolleschi fbshipit-source-id: 9984402ee427dd62d47dd716f73c030e6d0f7b5e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR runs eslint in PR using Danger.
Changelog
[General] [Changed] - Run ESLint in CI
Test Plan