-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for alignItems: baseline
for <Text> elements in Fabric
#31639
Conversation
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Base commit: 4090195 |
I am curious what tradeoffs you considered when introducing a bag of values named |
Just wanted to make it extensible (considering how many hoops we need to jump to pass values across multiple indirection layers). It's tricky to maintain a balance between extensibility, performance, simplicity, and clean looking code here. My assumption was that we will probably need to add more numeric text metrics in the future, so I called it extras to make it simpler in the future. Of course we can rename that to baseline. |
Base commit: 4090195 |
To clarify next steps here, I think we should rename to |
This PR is waiting for author's feedback since 24 days. Please provide the requested feedback or this will be closed in 7 days |
This PR was closed because the author hasn't provided the requested feedback after 7 days. |
Summary
This implements
alignItems: baseline
in Fabric for both platforms.This fixes #20666 and #21918 and others, see also #31575 and 51b3529.
Changelog
[Core][Fixed] - Support for
alignItems: baseline
for elements in FabricTest Plan