Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alignItems: baseline for <Text> elements on Android #31575

Closed
wants to merge 1 commit into from

Conversation

shergin
Copy link
Contributor

@shergin shergin commented May 23, 2021

Summary

This fixes #20666 and #21918.

This is pretty much the same as 51b3529 but implemented for Android.
Now exposes the actual base-line offset value that allows Yoga to position it properly when alignItems: baseline is requested.

Changelog

[Android][Fixed] - Fixed alignItems: baseline for elements on Android

Test Plan

The same test case that we have for iOS.
Before:
Screen Shot 2021-05-22 at 7 03 18 PM

After:
Screen Shot 2021-05-22 at 7 01 51 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 118489f

@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@shergin
Copy link
Contributor Author

shergin commented May 26, 2021

Btw, I just realized that this feature is not implemented in Fabric (my bad!). I fixed it locally now and it will be a PR after/if this one is merged.

@yungsters
Copy link
Contributor

Thanks! The only thing blocking me from landing this was finding time to test on Fabric, haha. So yeah, I definitely welcome a Fabric PR! And then I can import and get both reviewed and merged.

@shergin
Copy link
Contributor Author

shergin commented Jun 1, 2021

Okie-dokie, #31639 does that for Fabric. Ideally it should be a three-diff stack but... you know, git hub. :(

@yungsters
Copy link
Contributor

Thanks! I understand… 😞

I’ve imported both PRs already. Will do some extra testing and get them reviewed this week before I merge them.

@KingAmo
Copy link

KingAmo commented Jun 18, 2021

any news here?

@yungsters
Copy link
Contributor

We've had some folks on leave and vacation the past few weeks, but I finally got internal reviews completed. I'll need to do some additional testing before I merge these, but I should be able to get to those this week.

@yungsters yungsters self-assigned this Jul 28, 2021
@facebook-github-bot
Copy link
Contributor

@yungsters merged this pull request in 1acf334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flex alignItems "baseline" not aligning consistently like on web
6 participants