-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defaultProps from DatePickeriOS | #31605 #31608
Conversation
Hi @oguzturker8! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 118489f |
Hi @oguzturker8, thank you for your effort here! Can you split these up per issue and comment on them so I can assign them to you? We already have someone who claimed StatusBar #31607 -- can you please drop your changes to StatusBar? Going forward, I'm hoping people claim the issue first before committing a PR -- apologies for not clarifying that! I will update future parent issues with that disclaimer. |
Hi @lunaleaps, sorry for that. |
@oguzturker8 No worries! It was my bad for not communicating it clear enough! Thanks again for your contributions! |
It's better to create a new PR. Most of current commits are redundant. |
Summary
Removed defaultProps from core components;
mode: 'datetime'
prop Remove defaultProps in DatePickeriOS #31605Changelog
[iOS] [Removed] - Removed defaultProps from DatePickerIOS.ios.js
Test Plan
CI is passing BUT
test_android
&test_docker
give buck error.Used #31593 's a44c4bd & 395eb21 commits.