Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultProps from DatePickeriOS | #31605 #31608

Closed
wants to merge 7 commits into from
Closed

Remove defaultProps from DatePickeriOS | #31605 #31608

wants to merge 7 commits into from

Conversation

turker0
Copy link

@turker0 turker0 commented May 27, 2021

Summary

Removed defaultProps from core components;

Changelog

[iOS] [Removed] - Removed defaultProps from DatePickerIOS.ios.js

Test Plan

CI is passing BUT test_android & test_docker give buck error.
Used #31593 's a44c4bd & 395eb21 commits.

@facebook-github-bot
Copy link
Contributor

Hi @oguzturker8!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 118489f

@lunaleaps
Copy link
Contributor

Hi @oguzturker8, thank you for your effort here!

Can you split these up per issue and comment on them so I can assign them to you? We already have someone who claimed StatusBar #31607 -- can you please drop your changes to StatusBar?

Going forward, I'm hoping people claim the issue first before committing a PR -- apologies for not clarifying that! I will update future parent issues with that disclaimer.

@turker0
Copy link
Author

turker0 commented May 27, 2021

Hi @lunaleaps, sorry for that.
I didn't know i need to claim the issue before committing a PR. I'll be taking DatePickeriOS #31605 and updating the PR first. Thanks

@turker0 turker0 changed the title #31601 | Remove defaultProps from our core components Remove defaultProps from DatePickeriOS | #31605 May 27, 2021
@lunaleaps
Copy link
Contributor

@oguzturker8 No worries! It was my bad for not communicating it clear enough! Thanks again for your contributions!

@turker0
Copy link
Author

turker0 commented May 27, 2021

It's better to create a new PR. Most of current commits are redundant.

@turker0 turker0 closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants