Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaultProps in DatePickeriOS #31605

Closed
lunaleaps opened this issue May 26, 2021 · 4 comments
Closed

Remove defaultProps in DatePickeriOS #31605

lunaleaps opened this issue May 26, 2021 · 4 comments
Assignees
@Fannolo
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.

Comments

@lunaleaps
Copy link
Contributor

See parent issue #31601

Expected Results

defaultProps are removed in DatePickeriOS
@lunaleaps lunaleaps added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Component: DatePickerIOS labels May 26, 2021
@lunaleaps lunaleaps mentioned this issue May 26, 2021
Closed
6 tasks
@turker0 turker0 mentioned this issue May 27, 2021
Closed
@turker0
Copy link

turker0 commented May 27, 2021

Hi @lunaleaps!, I want to take this issue

@lunaleaps lunaleaps assigned lunaleaps and turker0 and unassigned lunaleaps May 27, 2021
@turker0 turker0 mentioned this issue May 27, 2021
Closed
@lunaleaps lunaleaps linked a pull request May 31, 2021 that will close this issue
removed defaultprops from DatePickerIOS #31619
Closed
@Fannolo
Copy link

Fannolo commented Aug 18, 2021 •
edited
Loading

@lunaleaps Can I take this issue?

Edit
I saw that the MR is still open and waiting for a feedback from the author, I can take his changes for the removal of the defaultProps and add the snapshot test to it

@lunaleaps
Copy link
Contributor Author

lunaleaps commented Aug 19, 2021 •
edited
Loading

@Fannolo Sounds good with me! Please request review from me when ready!

@lunaleaps lunaleaps assigned Fannolo and unassigned turker0 Aug 19, 2021
@Fannolo Fannolo mentioned this issue Aug 22, 2021
Closed
facebook-github-bot pushed a commit that referenced this issue Aug 25, 2021
@facebook-github-bot
refactor: remove DefeaultProps from the DatePickerIOS component (#32064)
2fb102b 
Summary:
Closes issue  #31605.
This is part of a bigger issue that plans to remove defaultProps from class components in order to provide a smoother transition to functional components.

## Changelog

[General] [Changed] - Remove defaultProps from the DatePickerIOS Component.
[General] [Test] - Added snapshot test for the new component

Pull Request resolved: #32064

Test Plan: Compiled the rn-tester folder to check if the behavior is consistent with the previous versions.

Reviewed By: lunaleaps

Differential Revision: D30492515

Pulled By: yungsters

fbshipit-source-id: ed2c5f3211742d528ff3f8e406a53cd7ea43d7e7
@Fannolo
Copy link

Fannolo commented Aug 26, 2021

@lunaleaps can we close this issue? Thanks!

@facebook facebook locked as resolved and limited conversation to collaborators Aug 26, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Fannolo Fannolo

Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. JavaScript Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed defaultprops from DatePickerIOS
4 participants
@lunaleaps @Fannolo @react-native-bot @turker0