Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fabric podspecs #23550

Closed
wants to merge 2 commits into from

Conversation

ericlewis
Copy link
Contributor

Summary

In service of #22989. This PR adds a podspec capable of building / linking fabric with RNTester. A lot of the folly work is based on @kmagiera commits a few months ago, found here.

Todo

  • Proper fix for Float.h conflicting with system headers. (Is a rename okay?)
  • SliderEventEmitter uses floats, which causes Xcode to complain
  • RCTSwitchComponentView references rncore, which appears to be missing
  • Importing RCTSurfacePresenter.h to AppDelegate causes header errors (due to not being objc++)
  • Check if all folly imports are required
  • Check if libevent is required.

Changelog

[iOS] [Added] - Fabric podspec

Test Plan

Pod install RCTFabric & RCTFabricSample & libevent to RNTester, run.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2019
@fkgozali
Copy link
Contributor

cc @shergin @JoshuaGross

also cc @fson who's looking into refactoring existing podspec (non fabric): #23559

@fson
Copy link
Contributor

fson commented Feb 20, 2019

#23559 splits the subspecs of React.podspec into separate podspecs, so it would be good to move Fabric to it's own podspecs too. Following the format introduced in RFC0004 and implemented in #23559, pending any changes, I think this could mean two podspec files for fabric:

  • Podspec for React-RCTFabric in ./React/Fabric/React-RCTFabric.podspec
  • Podspec for React-fabric in ./ReactCommon/fabric/React-fabric.podspec

@ericlewis
Copy link
Contributor Author

ericlewis commented Feb 20, 2019

@fson is it also worth putting the fabric subspecs in their respective folders (uimanager, view, text, etc)? It gets a little nested, so I am not sure if that is the right approach.

@ericlewis ericlewis closed this Feb 28, 2019
@ericlewis
Copy link
Contributor Author

I am unable to work on this further, anyone else is free to pick up where I left off.

@facebook-github-bot facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants