[React Fabric] Updating Build Configuration (CocoaPods, .xcodeproj, gradle) #22989

fkgozali · 2019-01-15T01:48:45Z

For Discussion

Various parts of React Fabric code are available in github, but we need to upgrade a bunch of build configuration to make it build properly on iOS and Android. This will involve reflecting the BUCK targets for various parts of Fabric into the 3 areas:

React.podspec (iOS) -- note that we had partial configs already, but very outdated.
React.xcodeproj (iOS)
build.gradle (Android)

An initial version of the update could just be manually sync'ed configs for .podspec, .xcodeproj, and .gradle.

But for the future, some ideas include:

Have BUCK generate the relevant .podspec, .xcworkspace, or .gradle -- this may require a bunch of work via buck project
etc

Requirements

Have RNTester built with Fabric symbols correctly (iOS/Android to start)
Upgraded version of Folly - see [META] Upgrading Folly #20302
- Note that we're on v2018.10.22 already (Upgrade folly to v2018.10.22.00 for iOS #21976, Upgrade folly to v2018.10.22.00 for Android #21977)

cc @mdvacca, @shergin

The text was updated successfully, but these errors were encountered:

danibonilha · 2019-01-28T22:12:45Z

Hey there! I'd like to help, so I started with the podspec, and I'd appreciate any tips, on how to test and make sure everything is working. Thanks.

fkgozali · 2019-01-29T18:18:01Z

on how to test and make sure everything is working

First step is to have RNTester podspec able to build Fabric specs (that includes all subspecs from fabric directory).

The next step after that is to actually use Fabric in RNTester. This is still work in progress for our team, so we can tackle that slightly later. cc @shergin

danibonilha · 2019-01-29T20:47:23Z

Hey, could you guys please verify if this include is correct? I'm getting an error 'Unknown type name 'CGFloat'' in this file and looking at the code '<CoreGraphics/CoreGraphics.h>' is always used with .m files and import instead of include and .cpp files.

fkgozali · 2019-01-29T21:56:25Z

Hey, could you guys please verify if this include is correct? I'm getting an error 'Unknown type name 'CGFloat'' in this file and looking at the code '<CoreGraphics/CoreGraphics.h>' is always used with .m files and import instead of include and .cpp files.

Does it work if you modify it to #import ? This builds fine using Buck at FB, perhaps there's a missing flag somewhere? Or perhaps you're missing the dependency on CoreGraphics iOS framework in the podspec?

If moving to #import works feel free to send a PR for it. Looking at a similar file, seems like we use #import there:

react-native/ReactCommon/fabric/imagemanager/platform/ios/RCTImagePrimitivesConversions.h

Line 8 in 94d49e5

#import <UIKit/UIKit.h>

grabbou · 2019-01-30T11:39:51Z

@fkgozali are there any question marks you see as far as using CocoaPods with Fabric/TurboModules? I'd love to hear more about your experience so far.

mgriepentrog · 2019-01-30T17:45:15Z

I can take a look at updating the xcodeproj files.

fkgozali · 2019-01-30T17:57:22Z

are there any question marks you see as far as using CocoaPods with Fabric/TurboModules? I'd love to hear more about your experience so far.

We don't use cocoapods/gradle internally, so I'm hoping the unknowns can be covered with the help from community on this issue.

danibonilha · 2019-02-11T20:56:11Z

Hey React.podspec is up for grabs again, I'm sorry, I didn't have enough time to finish it up.

mgriepentrog · 2019-02-14T15:14:54Z

I switched gears to updating the podspec (xcodeprojs are a pain). Here is what I have so far: mgriepentrog@44c5649. To find a lot of the low-hanging fruit, I'm running pod install inside of RNTester and trying to build the app with the RCTFabric subspec included. Currently encountering react-native/RNTester/Pods/Headers/Private/React/react/graphics/Geometry.h:55:3: Unknown type name 'Float'; did you mean 'float'?, but haven't had much time to investigate.

danibonilha · 2019-02-14T20:22:34Z

I switched gears to updating the podspec (xcodeprojs are a pain). Here is what I have so far: mgriepentrog@44c5649. To find a lot of the low-hanging fruit, I'm running pod install inside of RNTester and trying to build the app with the RCTFabric subspec included. Currently encountering react-native/RNTester/Pods/Headers/Private/React/react/graphics/Geometry.h:55:3: Unknown type name 'Float'; did you mean 'float'?, but haven't had much time to investigate.

I got stuck on the same problem, and couldn't get pass it I added same frameworks, changed some files and then same problem again. 😟

fkgozali · 2019-02-14T20:45:12Z

It looks like this header file wasn't included in your setup?

react-native/ReactCommon/fabric/graphics/platform/ios/Float.h

Line 18 in 3ad5c9e

using Float = CGFloat;

ericlewis · 2019-02-16T04:09:37Z

I made progress on getting the cocoapods to build and ran in to a few problems:

CGFloat in Float.h, same problems as above, it seems that the interop isn't working, I stubbed this with a double to continue.
RCTSwitchComponentView makes references to react/components/rncore/, which I could not find, nor could I find something similar.
~~Missing x86_64 Symbol Error on getDefaultComponentRegistryFactory, but that might be due to my stubbing?~~ <- This is due to missing folly imports.

I am still working on getting it to build a little further, and and still trying to figure out what is going on with Float.h.

But the podfile seems mostly complete: ericlewis@a6510d9. It creates libReact.a.

mgriepentrog · 2019-02-16T06:46:51Z

One thing I noticed, if you look at the Pods project under the Frameworks folder, the CoreGraphics framework is pointing to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk/System/Library/Frameworks/CoreGraphics.framework, which doesn't exist (the latest sdk version is 12.1). I'm not sure where that path is getting derived from.

ericlewis · 2019-02-16T13:59:55Z

I updated those frameworks manually to point to 12.1 & was no dice.

ericlewis · 2019-02-16T14:12:03Z

Here is my WIP: https://github.com/ericlewis/react-native/commits/fabric

pod files seem “done”
renaming Float.h fixes CGFloat issue. Conflicts somewhere.

Compiling this branch's RNTester with RCTFabric & RCTFabricSample works, it links correctly! But you must remove the fabric switch component refs, bc they ref something called rncore that appears to be missing.

ericlewis · 2019-02-18T13:56:48Z

Another issue too is I get a “functional file not found” in relation to what looks like libc++ headers in LayoutPrimitives.h, it also happens in SurfacePresenter with memory, tho that is fixed by a rename to memory.h.

I have not been able to figure out why this is happening, tho it is not happening in older versions of fabric using this same technique.

fkgozali · 2019-02-19T21:50:38Z

Another issue too is I get a “functional file not found” in relation to what looks like libc++ headers in LayoutPrimitives.h, it also happens in SurfacePresenter with memory, tho that is fixed by a rename to memory.h.

cc @shergin, @JoshuaGross -- thoughts?

ericlewis · 2019-02-19T23:44:55Z

@fkgozali I figured out what the issue was.. I am not sure I am using the library correctly, it happened when importing RCTSurfacePresenter.h, I believe the issue is due to AppDelegate.m not being an Objective-C++ file. It does link and build and run when I use RCTSurfaceHostingProxyRootView, but it is blank due to not having a presenter.

ericlewis · 2019-02-20T10:53:01Z

My current progress, open issues, and questions: #23550

fkgozali · 2019-02-20T17:31:02Z

I believe the issue is due to AppDelegate.m not being an Objective-C++ file

Ah, yeah a bunch of files need to become .mm instead. I think that's an ok requirement though, given the increasing number of C++ we're adding. That said, if AppDelegate.m needs to be AppDelegate.mm, let's switch it over. If you find more .m files to be converted to .mm, let's note them here as well.

ericlewis · 2019-03-07T07:17:19Z

Working podspecs: #23802

cpojer · 2019-03-19T12:53:39Z

RNTester now works with Fabric, and we have a separate issue dealing with folly so I'm gonna go ahead and close this issue.

@fkgozali feel free to reopen or create a new issue depending on whether you wanted to keep this issue as a meta issue for all Fabric work or just scoped to making things work in RNTester.

fkgozali · 2019-03-19T18:58:23Z

Hold on, this is the umbrella ask for fabric build, including android, so let's keep this open. What was done was just for CocoaPods.

fkgozali · 2019-03-19T19:00:28Z

Also what's not yet done:

component registration, integrated with build system (this doesn't exist in OSS yet)

kelset · 2021-06-18T11:16:19Z

@fkgozali should we close this off? :D

fkgozali · 2021-06-18T15:01:34Z

yes this is an old issue On Jun 18, 2021, at 4:16 AM, Lorenzo Sciandra ***@***.***> wrote: @fkgozali<https://github.com/fkgozali> should we close this off? :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22989 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAILROXV2YIAUZ4FJCHRSC3TTMTJJANCNFSM4GQAKN6A>.

fkgozali added Help Wanted Issues ideal for external contributors. Type: Discussion Long running discussion. labels Jan 15, 2019

fkgozali mentioned this issue Jan 29, 2019

Native Modules react-native-community/discussions-and-proposals#96

Closed

ericlewis mentioned this issue Feb 20, 2019

[WIP] Fabric podspecs #23550

Closed

6 tasks

cpojer mentioned this issue Mar 19, 2019

React Native London Issue Triage #24032

Closed

cpojer closed this as completed Mar 19, 2019

fkgozali reopened this Mar 19, 2019

kelset closed this as completed Jun 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[React Fabric] Updating Build Configuration (CocoaPods, .xcodeproj, gradle) #22989

[React Fabric] Updating Build Configuration (CocoaPods, .xcodeproj, gradle) #22989

fkgozali commented Jan 15, 2019 •

edited

Loading

danibonilha commented Jan 28, 2019 •

edited

Loading

fkgozali commented Jan 29, 2019

danibonilha commented Jan 29, 2019

fkgozali commented Jan 29, 2019 •

edited

Loading

grabbou commented Jan 30, 2019

mgriepentrog commented Jan 30, 2019

fkgozali commented Jan 30, 2019

danibonilha commented Feb 11, 2019

mgriepentrog commented Feb 14, 2019

danibonilha commented Feb 14, 2019

fkgozali commented Feb 14, 2019

ericlewis commented Feb 16, 2019 •

edited

Loading

mgriepentrog commented Feb 16, 2019

ericlewis commented Feb 16, 2019

ericlewis commented Feb 16, 2019 •

edited

Loading

ericlewis commented Feb 18, 2019

fkgozali commented Feb 19, 2019

ericlewis commented Feb 19, 2019

ericlewis commented Feb 20, 2019

fkgozali commented Feb 20, 2019 •

edited

Loading

ericlewis commented Mar 7, 2019

cpojer commented Mar 19, 2019

fkgozali commented Mar 19, 2019

fkgozali commented Mar 19, 2019

kelset commented Jun 18, 2021

fkgozali commented Jun 18, 2021 via email

[React Fabric] Updating Build Configuration (CocoaPods, .xcodeproj, gradle) #22989

[React Fabric] Updating Build Configuration (CocoaPods, .xcodeproj, gradle) #22989

Comments

fkgozali commented Jan 15, 2019 • edited Loading

For Discussion

Requirements

danibonilha commented Jan 28, 2019 • edited Loading

fkgozali commented Jan 29, 2019

danibonilha commented Jan 29, 2019

fkgozali commented Jan 29, 2019 • edited Loading

grabbou commented Jan 30, 2019

mgriepentrog commented Jan 30, 2019

fkgozali commented Jan 30, 2019

danibonilha commented Feb 11, 2019

mgriepentrog commented Feb 14, 2019

danibonilha commented Feb 14, 2019

fkgozali commented Feb 14, 2019

ericlewis commented Feb 16, 2019 • edited Loading

mgriepentrog commented Feb 16, 2019

ericlewis commented Feb 16, 2019

ericlewis commented Feb 16, 2019 • edited Loading

ericlewis commented Feb 18, 2019

fkgozali commented Feb 19, 2019

ericlewis commented Feb 19, 2019

ericlewis commented Feb 20, 2019

fkgozali commented Feb 20, 2019 • edited Loading

ericlewis commented Mar 7, 2019

cpojer commented Mar 19, 2019

fkgozali commented Mar 19, 2019

fkgozali commented Mar 19, 2019

kelset commented Jun 18, 2021

fkgozali commented Jun 18, 2021 via email

fkgozali commented Jan 15, 2019 •

edited

Loading

danibonilha commented Jan 28, 2019 •

edited

Loading

fkgozali commented Jan 29, 2019 •

edited

Loading

ericlewis commented Feb 16, 2019 •

edited

Loading

ericlewis commented Feb 16, 2019 •

edited

Loading

fkgozali commented Feb 20, 2019 •

edited

Loading