Link all platforms #17834
Closed
Link all platforms #17834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.
facebook-github-bot
added
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot large-pr Generated by 🚫 dangerJS |
rozele
commented
Feb 2, 2018
| @@ -126,3 +126,5 @@ exports.dependencyConfig = function dependencyConfigAndroid(folder, userConfig) | |||
|
|
|||
| return { sourceDir, folder, manifest, packageImportPath, packageInstance }; | |||
| }; | |||
|
|
|||
| exports.linkConfig = require('../../link/android'); | |||
There was a problem hiding this comment.
Add same for iOS #Closed
rozele
commented
Feb 2, 2018
local-cli/link/unlink.js
Outdated
| }; | ||
| const linkConfig = platforms[platform] && platforms[platform].linkConfig && platforms[platform].linkConfig(); | ||
| if (!linkConfig || !linkConfig.isInstalled || !linkConfig.unregister) { | ||
| return null; |
There was a problem hiding this comment.
null [](start = 15, length = 4)
return; #Closed
rozele
commented
Feb 2, 2018
| const isIosInstalled = isInstalledIOS(projectConfig, dependencyConfig); | ||
| const isPodInstalled = isInstalledPods(projectConfig, dependencyConfig); | ||
| if (isIosInstalled) { | ||
| const allDependencies = getDependencyConfig(config, getProjectDependencies()); |
There was a problem hiding this comment.
getProjectDependencies [](start = 56, length = 22)
need to import #Closed
rozele
commented
Feb 2, 2018
| const isPodInstalled = isInstalledPods(projectConfig, dependencyConfig); | ||
| if (isIosInstalled) { | ||
| const allDependencies = getDependencyConfig(config, getProjectDependencies()); | ||
| const otherDependencies = filter(allDependencies, d => d.name !== packageName); |
There was a problem hiding this comment.
packageName [](start = 70, length = 11)
name? #Closed
rozele
commented
Feb 2, 2018
| registerDependencyPods(name, dependencyConfig, projectConfig); | ||
| } | ||
| else { | ||
| registerDependencyIOS(name, dependencyConfig, projectConfig); |
There was a problem hiding this comment.
name [](start = 26, length = 4)
I don't think this takes a name param. #Closed
The previous commit added logic to allow platforms to self-configure their link behavior. The commit kept a special case for iOS and Android intact. This commit removes the special cases.
|
@rozele do you think we should cherry-pick this back to 0.53/0.52/0.51? |
|
Yup, got it.
…On Tue, 6 Feb 2018 at 14:53 Eric Rozell ***@***.***> wrote:
@grabbou <https://github.com/grabbou> - yes please do cherry-pick back to
these versions (and 0.50 if possible), but this PR was closed in favor of
#17745 <#17745>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17834 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxpAllrGDXz0n_VY9Uw0QWK5sZakfks5tSFligaJpZM4R3HXD>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@grabbou requested that we eliminate the special cases for iOS and Android in
linkandunlinkcommands.Test Plan
jesttests continue to work.Related PRs
#17745
Release Notes
[INTERNAL] [ENHANCEMENT ] [local-cli/info/link.js] - Make link and unlink more maintainable for all platforms.