Enable platforms to configure CLI commands #17745

rozele · 2018-01-25T19:30:48Z

This change adds hooks via the package.json for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in link and unlink commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.

Motivation

We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

All jest tests, including new tests, pass.
link and unlink commands are successful on iOS and Android.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)

microsoft/react-native-windows#1601

Release Notes

[CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig.
[CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the link command.
[CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the unlink command.

pull-bot · 2018-01-25T19:31:46Z

	Warnings
⚠️	❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 733 lines.

@facebook-github-bot label Android

@facebook-github-bot large-pr

Attention: @grabbou, @Kureev

Generated by 🚫 dangerJS

eslint-bot · 2018-01-25T19:32:10Z

local-cli/link/unlink.js

+        dependency[platform],
+        project[platform]
+      );
+


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2018-01-25T19:32:10Z

local-cli/core/__tests__/findPlugins.spec.js

+    expect(findPlugins([ROOT])).toHaveProperty('commands');
+    expect(findPlugins([ROOT])).toHaveProperty('platforms');
+    expect(findPlugins([ROOT]).commands).toHaveLength(2);
+    expect(findPlugins([ROOT]).platforms).toHaveLength(0);    


prettier/prettier: Delete ····

eslint-bot · 2018-01-25T21:17:21Z

local-cli/link/unlink.js


-  log.info(`Windows module ${packageName} has been successfully unlinked`);
+      log.info(`Unlinking ${packageName} ${platform} dependency`);


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2018-01-25T21:17:21Z

local-cli/link/link.js

+      }
+
+      return pollParams(dependency.config.params).then(params => {
+        log.info(`Linking ${dependency.name} ${platform} dependency`);


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2018-01-25T21:24:06Z

local-cli/link/link.js

+          params,
+          project[platform]
+        );
+


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2018-01-25T21:24:06Z

local-cli/core/index.js

@@ -55,10 +58,20 @@ const attachPackage = (command, pkg) => Array.isArray(command)
  ? command.map(cmd => attachPackage(cmd, pkg))
  : { ...command, pkg };


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2018-01-25T21:24:06Z

local-cli/link/__tests__/link.spec.js

+      '../android/isInstalled.js',
+      sinon.stub().returns(true)
+    );
+


jest/valid-expect: No assertion was called on expect().

eslint-bot · 2018-01-25T21:28:54Z

local-cli/link/unlink.js


-  log.info(`Windows module ${packageName} has been successfully unlinked`);
+      log.info(`Unlinking ${packageName} ${platform} dependency`);


no-trailing-spaces: Trailing spaces not allowed.

eslint-bot · 2018-01-25T21:28:54Z

local-cli/link/unlink.js

+        dependency[platform],
+        project[platform]
+      );
+


no-trailing-spaces: Trailing spaces not allowed.

grabbou · 2018-01-25T23:14:07Z

This is great! Looking into the code right now, but I think the ability to extend built-in commands is another big step towards decoupling CLI from being android / ios only.

grabbou

Leaving some preliminary feedback. Will probably get more as I dive deeper into the codebase.

Please let me know what you think :)

grabbou · 2018-01-25T23:16:16Z

local-cli/core/findPlugins.js

+  const plugins = folders.map(findPluginInFolder);
+  return {
+    commands: uniq(flatten(plugins.map(p => flatten(p.commands)))),
+    platforms: uniq(flatten(plugins.map(p => flatten(p.platforms))))


I am not sure I am getting that line - the commands flattening is to make a flat array of all commands (if plugin defines many, we handle that).

What's the purpose of it for platforms? I get that we want to get a list of all platforms defined throughout the plugins - but when do we use it later?

Not sure if the question here is related to platforms and why it's mangled with commands, or specifically why we flatten the platforms collection, so I'll address both.

platforms is used by local-cli/core/index.js and the link and unlink command to evaluate projectConfig(), dependencyConfig(), and linkConfig(). I would have created a separate module to extract the platform info, but I didn't want to impact CLI perf. If I created a separate module, I would have to read package.json for each potential plugin twice (instead of once as is done here).

In terms of why we flatten the collection of platforms - plugins could potentially define multiple platforms (e.g., uwp and win32, or ios and android), so I flatten the list so we have one array of all platforms used for configuration and in link.

@grabbou - I removed the inner flatten. The problem was that I had switched from concat to push.

grabbou · 2018-01-25T23:17:24Z

local-cli/core/index.js

+    return flatten(commands);
+  },
+
+  getPlatformConfig(): Object {


Looks like this can be just a function, so that no need to call this.... later to refer to it?

True. I'll fix.

#WontFix - @grabbou, we need to expose the getPlatformConfig() on the RNConfig so that it can be used later by other commands (like link).

grabbou · 2018-01-25T23:19:26Z

local-cli/link/link.js

-  });
+const linkDependencyPlatforms = (platforms, project, dependency) => {
+  const ignorePlatforms = ['android', 'ios'];
+  Object.keys(platforms || [])


Okay, so the approach you have taken here is to explicitly do platform link. How about making it so that when plugin defines link command, it will be run like this:

originalLink().then(linkOfPlugin)

That way, we could not only allow react-native-windows to hook into link but potentially init and others. It would be also a bit less hardcoded then the following code.

#WontFix - @grabbou For most commands there wouldn't be any problems with this. commander doesn't enforce one command to one key. E.g., I could easily define link in the react-native-windows project, and commander would just execute both the link from react-native and from react-native-windows. However - the semantics of link are as follows:

Run prelink scripts

Run link for all platforms

Run postlink scripts

If I did originalLink().then(linkOfPlugin), we would probably need to breakdown prelink and postlink per platform as well (not the worst idea), e.g.:

prelink for iOS

link iOS

postlink for iOS

prelink for Android
...

That is a much more involved change that I didn't want to undertake.

Regarding init - init is a very difficult case because it's actually implemented partially by the react-native-cli global tool, and we currently do some heuristics to match the version of react-native-windows to the current installed version of react-native. Not saying its impossible, but I think init will require some other infrastructure. For other commands, there's no reason why we can't just define upgrade, eject, info, etc. in the plugim and just have it work as you propose. The best part is it doesn't require any code change because of the functionality built into commander!

grabbou · 2018-01-25T23:19:59Z

local-cli/link/link.js

-    log.info(`Windows module ${dependency.name} has been successfully linked`);
-  });
+const linkDependencyPlatforms = (platforms, project, dependency) => {
+  const ignorePlatforms = ['android', 'ios'];


Is there any reason why android and ios can't have the same code path?

They can, I just wanted to keep the diff small.

#WontFix - @grabbou There's currently some custom linking logic related to podfile for iOS. Let's do these changes in two phases:

Remove windows and support platform extensions.

Treat iOS and Android equivalent to any platform extension.

eslint-bot · 2018-01-26T18:00:52Z

local-cli/link/link.js

-    log.info(`Windows module ${dependency.name} has been successfully linked`);
-  });
+const linkDependencyPlatforms = (platforms, project, dependency) => {
+  const ignorePlatforms = ['android', 'ios'];


element of Object.keys Expected object instead of empty array literal

rozele · 2018-01-26T18:24:33Z

local-cli/core/findPlugins.js

@@ -37,11 +37,19 @@ const findPluginsInReactNativePackage = (pjson) => {
  return path.join(pjson.name, pjson.rnpm.plugin);
 };

+const findPlatformsInPackage = (pjson) => {
+  if (!pjson.rnpm || !pjson.rnpm.plugin) {


plugin -> platform

rozele · 2018-01-26T18:28:39Z

local-cli/link/unlink.js


  try {
+    platforms = config.getPlatformConfig();


@grabbou - here is one example of where we need to call getPlatformConfig() on the RNConfig.

grabbou · 2018-01-30T18:28:09Z

@Kureev please let me know what you think. I think this approach is temporarily okayish to me (although I am not a fan of custom platform-specific code in link and unlink itself).

rozele · 2018-01-31T08:57:56Z

@grabbou by custom platform-specific code, you're referring to the iOS and Android stuff, right? I really think the best way to move forward is incremental change (i.e., fix iOS and Android in a separate PR). It's safer / gives us more confidence we're not breaking iOS and Android and keeps the diff small. cc @Kureev

rozele · 2018-01-31T09:16:44Z

cc @hramos (I think you said you were interested in this PR).

grabbou · 2018-02-01T17:46:43Z

@rozele true, I am just afraid that with no-one being interested in getting the codebase into its intended final shape, link will be left half-way done for a long time.

I have a plan on how to make this more "clean", but with you, being the only react-native-x I am aware (a platform), I am not sure if it's still a valid concern.

I guess we can merge it as is having another pair of the eyes to look at it.

rozele · 2018-02-02T13:59:03Z

Hey @grabbou - this is no longer half-baked, can we merge without a second opinion?

grabbou · 2018-02-02T14:22:40Z

Looks good to me - let's ship and I'll check before cherry-picking

grabbou · 2018-02-02T14:22:45Z

@facebook-github-bot shipit

facebook-github-bot

@grabbou is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

hramos · 2018-02-08T01:19:02Z

This PR did not land as it could not be applied cleanly. Looks like this still needs to be rebased. Can you try again?

Kureev

Wow! Great job, @rozele 🙌

Kureev · 2018-02-08T09:32:55Z

Rebase (or let me know if I can do it for you) and ping me, I'll ship it 😉

This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.

rozele · 2018-02-08T11:26:38Z

Thanks @Kureev and @hramos - I just rebased.

Kureev · 2018-02-08T12:17:56Z

@facebook-github-bot shipit

facebook-github-bot · 2018-02-08T12:18:18Z

Something went wrong executing that command, @mkonicek could you take a look?

facebook-github-bot

@Kureev is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

eastcoastcoder · 2018-02-11T05:39:01Z

Any idea when this will land? Not having a functional link for UWP apps is a real downer.

grabbou · 2018-02-12T15:05:35Z

@ethanx94 this is out as a 0.54.0-rc.0 right now - I'll be releasing patches in a backwards compatible manner tomorrow.

Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. #17745  [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes #17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363

Summary: This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.  We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) - All jest tests, including new tests, pass. - `link` and `unlink` commands are successful on iOS and Android. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) microsoft/react-native-windows#1601  [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig. [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command. [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command. Closes #17745 Differential Revision: D6883558 Pulled By: hramos fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b

Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. #17745  [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes #17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363

Summary: This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.  We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) - All jest tests, including new tests, pass. - `link` and `unlink` commands are successful on iOS and Android. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) microsoft/react-native-windows#1601  [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig. [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command. [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command. Closes #17745 Differential Revision: D6883558 Pulled By: hramos fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b

Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. #17745  [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes #17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363

Summary: This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.  We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) - All jest tests, including new tests, pass. - `link` and `unlink` commands are successful on iOS and Android. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) microsoft/react-native-windows#1601  [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig. [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command. [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command. Closes #17745 Differential Revision: D6883558 Pulled By: hramos fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b

Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. #17745  [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes #17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363

Summary: This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.  We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) - All jest tests, including new tests, pass. - `link` and `unlink` commands are successful on iOS and Android. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) microsoft/react-native-windows#1601  [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig. [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command. [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command. Closes facebook#17745 Differential Revision: D6883558 Pulled By: hramos fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b

Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. facebook#17745  [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes facebook#17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363

Summary: This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules.  We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) - All jest tests, including new tests, pass. - `link` and `unlink` commands are successful on iOS and Android. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) microsoft/react-native-windows#1601  [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig. [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command. [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command. Closes facebook/react-native#17745 Differential Revision: D6883558 Pulled By: hramos fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b

Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. facebook/react-native#17745  [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes facebook/react-native#17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363

rozele requested review from grabbou and Kureev as code owners January 25, 2018 19:30

eslint-bot reviewed Jan 25, 2018

View reviewed changes

local-cli/link/unlink.js Outdated

dependency[platform],

project[platform]

);

Copy link

eslint-bot Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-trailing-spaces: Trailing spaces not allowed.

eslint-bot reviewed Jan 25, 2018

View reviewed changes

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Jan 25, 2018

eslint-bot reviewed Jan 25, 2018

View reviewed changes

local-cli/link/link.js

params,

project[platform]

);

Copy link

eslint-bot Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-trailing-spaces: Trailing spaces not allowed.

eslint-bot reviewed Jan 25, 2018

View reviewed changes

local-cli/link/unlink.js Outdated

dependency[platform],

project[platform]

);

Copy link

eslint-bot Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-trailing-spaces: Trailing spaces not allowed.

grabbou suggested changes Jan 25, 2018

View reviewed changes

eslint-bot reviewed Jan 26, 2018

View reviewed changes

rozele commented Jan 26, 2018

View reviewed changes

rozele mentioned this pull request Feb 2, 2018

Link all platforms #17834

Closed

grabbou approved these changes Feb 2, 2018

View reviewed changes

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 2, 2018

facebook-github-bot approved these changes Feb 2, 2018

View reviewed changes

facebook-github-bot approved these changes Feb 5, 2018

View reviewed changes

Kureev approved these changes Feb 8, 2018

View reviewed changes

facebook-github-bot added the Failed Commands label Feb 8, 2018

facebook-github-bot approved these changes Feb 8, 2018

View reviewed changes

rozele mentioned this pull request Feb 8, 2018

react-native link: Error: ENOENT: no such file or directory, open <path>\MainPage.cs microsoft/react-native-windows#1578

Closed

facebook-github-bot closed this in a40bfa7 Feb 8, 2018

rozele mentioned this pull request Feb 13, 2018

Uses a single code path to link and unlink all platforms #17961

Closed

hramos added the Merged This PR has been merged. label Mar 8, 2019

react-native-bot removed Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed labels Mar 8, 2019


		log.info(`Windows module ${packageName} has been successfully unlinked`);
		log.info(`Unlinking ${packageName} ${platform} dependency`);

		@@ -55,10 +58,20 @@ const attachPackage = (command, pkg) => Array.isArray(command)
		? command.map(cmd => attachPackage(cmd, pkg))
		: { ...command, pkg };

Enable platforms to configure CLI commands #17745

Enable platforms to configure CLI commands #17745

Conversation

rozele commented Jan 25, 2018 • edited Loading

Motivation

Test Plan

Related PRs

Release Notes

pull-bot commented Jan 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grabbou commented Jan 25, 2018

grabbou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Jan 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Jan 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grabbou commented Jan 30, 2018

rozele commented Jan 31, 2018

rozele commented Jan 31, 2018

grabbou commented Feb 1, 2018

rozele commented Feb 2, 2018

grabbou commented Feb 2, 2018

grabbou commented Feb 2, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

hramos commented Feb 8, 2018

Kureev left a comment

Choose a reason for hiding this comment

Kureev commented Feb 8, 2018 • edited Loading

rozele commented Feb 8, 2018

Kureev commented Feb 8, 2018

facebook-github-bot commented Feb 8, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

eastcoastcoder commented Feb 11, 2018

grabbou commented Feb 12, 2018

rozele commented Jan 25, 2018 •

edited

Loading

pull-bot commented Jan 25, 2018 •

edited

Loading

rozele Jan 26, 2018 •

edited

Loading

rozele Jan 25, 2018 •

edited

Loading

rozele Jan 26, 2018 •

edited

Loading

Kureev commented Feb 8, 2018 •

edited

Loading