Update wed 13 may #1264
Merged
Update wed 13 may #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Previously it was possible for a gesture to be granted initiated if the start direction is not respected before the gesture detection distance gets reached, if the gesture direction is met eventually. This change ensures the gesture gets started in the right direction, otherwise the gesture action will set the responder. @public Test Plan: Fixes left-right swiping issue in AdsManager when a vertical swipe is intended.
Summary: Sometimes, when quicly backing out of a gesture, the scene isn't fully reset to the middle position and remains offset by a few pixels. This makes sure that never happens. @public Test Plan: Tested on iOS and I can no longer see the scenes stop when backing out of a gesture
Summary: Apparently British spelling is "cancelled", American is "canceled"? Picking "cancelled" for consistency with UIKit. @public Test Plan: landcastle
Summary: Add `AlertIOS.prompt` It's compatible with the js spec, with the exception that I had to add a callback param since it's async. Also supports the same button configuration as `AlertIOS.alert`. @public Test Plan: I've updated the `AlertIOS` example on UIExplorer with every valid combination of parameters, so just going through it should be fine.
Summary: In some situations, when quickly swiping back to a scene we are transitioning from, the scene is blank/missing. This is fixed by adding a check for the active gesture when we hide the scenes. @public Test Plan: Can no longer reproduce on simulator when quickly swiping back to the scene we are transitioning from
Summary: Fixes facebook#457 Closes facebook#482 Github Author: Vladimir Kurchatkin <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
…s held Summary: The RCTRootView creates a underlying RCTRootContentView that was deallocated when the bridge modules were deallocated. That doesn't work when the bridge is held. @public Test Plan: Launch Groups, put a breakpoint on `-[RCTRootContentView dealloc]`, enter and leave a group page. It should be called now.
…tches name exported with @providesModule.
Summary: @public Adds a couple of things: * `autoStart` option, which warms up the worker farm as opposed to spin up children on demand * worker-farm now passes properties on errors from children to parent (for line/col number in errors without resorting to hacks) Test Plan: * Run the server with --reset-cache * things work
Summary: When gesturing rapidly between scenes, the navigator can get into an unresponsive state. A few minor fixes can avoid that case @public Test Plan: Rapid gestures on iOS device and simulator can no longer get into bad state
Summary: The index alone isn't so useful; pass the route as well. (I am using this to implement componentWill/DidFocus in a library instead of onWill/DidFocus; facebook#1153). Closes facebook#1154 Github Author: James Ide <[email protected]> @public Test Plan: Set up a navigator with a couple of scenes, and see that when onItemRef is called for each one, the route is passed in as the third argument.
Summary: float from left animation for Navigator.SceneConfigs facebook#1100 @ericvicenti @ide Closes facebook#1249 Github Author: Logan Bernard <[email protected]> @public Test Plan: Video: https://drive.google.com/file/d/0B9HtmABaCcR0Zi1yNkl5UDhWbzg/view
Summary: After the RCTBatchedBridge refactor, the `-[NSNotificationCenter addObserver]` and `[removeObserver]` calls got divided between RCTBridge and RCTBatchedBridge. This diff does two things: - Moved `removeObserver` out of RTCBatchedBridge and into `-[RCTBridge invalidate]` - Moved `addObserver` from `bindKeys` to `setUp`. This is so that `-[RCTBridge reload]` will re-add the observer after invalidating and removing the observer cc @tadeuzagallo Closes facebook#1212 Github Author: James Ide <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: Add the RCTBatchedBridge object to the notification's userInfo for consistency with RCTJavaScriptDidLoadNotification, and set the target object to `_parentBridge`. cc @nicklockwood @tadeuzagallo Closes facebook#1243 Github Author: James Ide <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: We need to unset `clipsToBounds` on both the wrapper and the inner custom scroll view @public Test Plan: `overflow: 'visible'` actually shows content outside the `ScrollView` (e.g. for full-bleed horizontal scrollers/carousels). It doesn't pick up touches though, which is a wider issue.
Summary: Adds a CocoaPods subspec for ART. Closes facebook#1208 Github Author: James Ide <[email protected]> Test Plan: Pull in the subspec and run the VectorWidget example from react-art.
rozele
referenced
this pull request
in microsoft/react-native-windows
May 25, 2016
Update wed 13 may
hsjoberg
pushed a commit
to hsjoberg/react-native
that referenced
this pull request
Sep 8, 2022
Allow to render a scrollView's content in inverted order which is especially helpful in messaging applications. We can't rely on -1 scale hacks on macOS because of inverse issues with trackpad/scrollwheel, dragging scrollbars, tracking hovers, etc. Hence we added 'native' support for inverted views Co-authored-by: Scott Kyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.