Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _window to get content height and width #1264

Closed
wants to merge 3 commits into from
Closed

Use _window to get content height and width #1264

wants to merge 3 commits into from

Conversation

scott108
Copy link
Contributor

@scott108 scott108 commented Aug 3, 2017

It will get null reference content when run on release bundle mode, so I use _window to get ActualHight and ActualWidth, and it works fine

@msftclas
Copy link

msftclas commented Aug 3, 2017

@scott108,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@scott108 scott108 closed this Aug 3, 2017
@scott108 scott108 reopened this Aug 3, 2017
@msftclas
Copy link

msftclas commented Aug 3, 2017

@scott108,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

Codecov Report

Merging #1264 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
- Coverage   31.84%   31.83%   -0.02%     
==========================================
  Files         258      258              
  Lines       18674    18677       +3     
  Branches     1580     1583       +3     
==========================================
- Hits         5947     5945       -2     
- Misses      12574    12577       +3     
- Partials      153      155       +2
Impacted Files Coverage Δ
...ative.Net46/Views/Scroll/ReactScrollViewManager.cs 0% <ø> (ø) ⬆️
...ative.Net46/Modules/DeviceInfo/DeviceInfoModule.cs 0% <0%> (ø) ⬆️
...dows/ReactNative.Shared.Tests/Internal/AssertEx.cs 84% <0%> (-4%) ⬇️
...ts/Modules/Network/TaskCancellationManagerTests.cs 93.7% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c83384...875e19c. Read the comment docs.

@scott108 scott108 closed this Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants