-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.55.0] Metro Bundler can't listen on port undefined #18681
Comments
Thanks for posting this! It looks like your issue may be incomplete. Are all the fields required by the Issue Template filled out? If you believe your issue contains all the relevant information, let us know in order to have a maintainer remove the No Template label. Thank you for your contributions. |
Can confirm that using react-native: 0.52.2 fixed this issue for me. |
This is happening to me too, 0.52.2 with React 16.2.0 fixed it. |
Apparently this is related to #18525, that issue fixes device but simulator is still broken, because https://github.com/facebook/react-native/blob/master/local-cli/runIOS/runIOS.js#L130 Adding |
after updating npm i also get error when running command react-native init-ios. I have following versions of NPM, react-native, node js |
@shivawu That patch is already included in RN |
I am experiencing the same issue with 0.55.0. |
Same here! |
First off, PLEASE don't pollute the issue with useless 'same issue' comments. There are the reactions for indicating that this issue is present. That said, please don't use 0.55.0 because it ships with the wrong version of React. We are going to release soon a new version. |
I believe we need to fix this as soon as possible - @kitze was reporting this to me yesterday. I will take a closer look before releasing a new version. |
@wouterds if you read through my comment, I provided another fix for this current problem, that issue is only a reference |
I have to say the release process has been very carelessly, recently.
Each major release has flaws that makes it unusable. Especially with 0.54 and 0.55. I always have postinstall script setup to fix react-native. Feel like it’s SEV worthy and time to revise the process |
@shivawu the release spends around a month as a release candidate. That's a great time to give the RC a try and surface any issues, prior to the stable release being cut. |
I’m aware of the Rc version and really appreciated the effort. Yet these seems-easy-to-discover bugs slipped through into the stable release, just saying there seems the process can be improved |
Definitely. Beefing up our test suite is another way of contributing a solution to this. I'd appreciate any PRs in that area. |
That's not the same patch. That one is on line 71, which fixes for devices, mine is on line 130, which fixes simulator. |
@shivawu: I rest my case. 😅 |
I know, it's super confusing, for a minute I bought what you said, lol 😂 |
The regression has been introduced in this commit: 2ad3407. I am going to fix it by adding |
You can find a fix here: 589eae1 |
@shivawu The releases are cut very carefully, but there's just too many pieces to test at one time. That's why having people to use release candidates would prevent such obvious errors from leaking into production. Recent issues have to do with |
Yeah, I fixed both in 0.55.
react-native-community/releases#11 (comment)
…On Thu, 5 Apr 2018 at 23:50 Mateo Guzmán ***@***.***> wrote:
With this solution #18681 (comment)
<#18681 (comment)>
the metro bundler works. But, still appearing this error.
[image: image]
<https://user-images.githubusercontent.com/20783123/38393680-3285f4ee-38f1-11e8-9fee-4fcd385e2ca2.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18681 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxvQXBEOP_1y35EfG4NMBnz4uyFXrks5tlpHBgaJpZM4TF1kc>
.
|
@grabbou I upgraded to 0.55 and run |
Interesting. I had it already launched (you can turn it on by pressing CMD
Space and typing simulator).
I'll take a closer look at the full run ios diff, that's alarming if this
feature doesn't work either.
…On Fri, Apr 6, 2018, 6:26 AM Welly ***@***.***> wrote:
@grabbou <https://github.com/grabbou> I upgraded to 0.55 and run react-native
run-ios it build success but the simulator won't be triggered. so wired...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18681 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxkWj14c3lCenGrWNuY_Lm-AB0kDmks5tlu50gaJpZM4TF1kc>
.
|
@grabbou Thank you for this temporary solution. |
Here's my proposed fix:
2ad3407#r28448345
Waiting
for feedback and will release a patch.
I am really sorry for all the inconvenience issues with the command line
tools caused for you. For the future, we will make sure to pay even more
attention to commits affecting the CLI.
…On Fri, 6 Apr 2018 at 09:10 Welly ***@***.***> wrote:
@grabbou <https://github.com/grabbou> Thank you for this temporary
solution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18681 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxjyOpbbcu0SBIaxxVa4cZBKtLJAzks5tlxTqgaJpZM4TF1kc>
.
|
Here's PR: #18721. I'll probably merge it today and once 0.55 is out, make a PR back to |
Summary: Regression introduced in facebook@2ad3407. Fixes facebook#18681 Closes facebook#18722 Differential Revision: D7535684 Pulled By: hramos fbshipit-source-id: 21bc79091148daba7b668965cd5becaa43117721
This doesn't happen with React |
Summary: Regression introduced in facebook@2ad3407. Fixes facebook#18681 Closes facebook#18722 Differential Revision: D7535684 Pulled By: hramos fbshipit-source-id: 21bc79091148daba7b668965cd5becaa43117721
Summary: Regression introduced in facebook/react-native@2ad3407. Fixes facebook/react-native#18681 Closes facebook/react-native#18722 Differential Revision: D7535684 Pulled By: hramos fbshipit-source-id: 21bc79091148daba7b668965cd5becaa43117721
I am following up on closed issue #18673. This still seems to be an issue. Here's a screenshot of what I'm experiencing. Is there something I am missing?
Environment
OS: macOS High Sierra 10.13.3
Node: 7.9.0
Yarn: Not Found
npm: 4.2.0
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.1 AI-173.4670197
Packages: (wanted => installed)
react: 16.3.0 => 16.3.0
react-native: 0.55.0 => 0.55.0
Steps to Reproduce
Expected Behavior
Build Successful!
Actual Behavior
Metro Bundler can't listen on port undefined
The text was updated successfully, but these errors were encountered: