Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.55.0] Metro Bundler can't listen on port undefined #18681

Closed
3 tasks done
ASteinheiser opened this issue Apr 3, 2018 · 29 comments
Closed
3 tasks done

[0.55.0] Metro Bundler can't listen on port undefined #18681

ASteinheiser opened this issue Apr 3, 2018 · 29 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ASteinheiser
Copy link

ASteinheiser commented Apr 3, 2018

I am following up on closed issue #18673. This still seems to be an issue. Here's a screenshot of what I'm experiencing. Is there something I am missing?

screen shot 2018-04-03 at 2 44 27 pm

Environment

OS: macOS High Sierra 10.13.3
Node: 7.9.0
Yarn: Not Found
npm: 4.2.0
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.1 AI-173.4670197

Packages: (wanted => installed)
react: 16.3.0 => 16.3.0
react-native: 0.55.0 => 0.55.0

Steps to Reproduce

react-native init AwesomeProject
cd AwesomeProject
react-native run-ios

Expected Behavior

Build Successful!

Actual Behavior

Metro Bundler can't listen on port undefined

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like your issue may be incomplete. Are all the fields required by the Issue Template filled out?

If you believe your issue contains all the relevant information, let us know in order to have a maintainer remove the No Template label. Thank you for your contributions.

How to ContributeWhat to Expect from Maintainers

@ASteinheiser
Copy link
Author

Can confirm that using react-native: 0.52.2 fixed this issue for me.

@leofontes
Copy link

This is happening to me too, 0.52.2 with React 16.2.0 fixed it.

@zen0wu
Copy link

zen0wu commented Apr 4, 2018

Apparently this is related to #18525, that issue fixes device but simulator is still broken, because port is not passed into buildProject.

https://github.com/facebook/react-native/blob/master/local-cli/runIOS/runIOS.js#L130

Adding args.port as the last argument to this function call should temporarily fix the issue

@kaushal9678
Copy link

after updating npm i also get error when running command react-native init-ios.
React Native 0.55.0 CFBundleIdentifier error after fixing metro port
But the projects that are created with lower version is works fine without any error.

I have following versions of NPM, react-native, node js
react-native-cli: 2.0.1
react-native: 0.55.0,
I downgrade NPM version to this npm 3.10.10
node -verison v6.14.1

@wouterds
Copy link

wouterds commented Apr 4, 2018

@shivawu That patch is already included in RN 0.55, it does not fix the issue. It did work on 0.54.4.

@hatlestad
Copy link

I am experiencing the same issue with 0.55.0.

@donjordano
Copy link

Same here!

@kelset
Copy link
Contributor

kelset commented Apr 4, 2018

First off, PLEASE don't pollute the issue with useless 'same issue' comments.

There are the reactions for indicating that this issue is present.

That said, please don't use 0.55.0 because it ships with the wrong version of React. We are going to release soon a new version.

@grabbou
Copy link
Contributor

grabbou commented Apr 4, 2018

I believe we need to fix this as soon as possible - @kitze was reporting this to me yesterday. I will take a closer look before releasing a new version.

@zen0wu
Copy link

zen0wu commented Apr 4, 2018

@wouterds if you read through my comment, I provided another fix for this current problem, that issue is only a reference

@zen0wu
Copy link

zen0wu commented Apr 4, 2018

I have to say the release process has been very carelessly, recently.

Each major release has flaws that makes it unusable. Especially with 0.54 and 0.55. I always have postinstall script setup to fix react-native. Feel like it’s SEV worthy and time to revise the process

@hramos
Copy link
Contributor

hramos commented Apr 4, 2018

@shivawu the release spends around a month as a release candidate. That's a great time to give the RC a try and surface any issues, prior to the stable release being cut.

@zen0wu
Copy link

zen0wu commented Apr 4, 2018

I’m aware of the Rc version and really appreciated the effort. Yet these seems-easy-to-discover bugs slipped through into the stable release, just saying there seems the process can be improved

@hramos
Copy link
Contributor

hramos commented Apr 4, 2018

Definitely. Beefing up our test suite is another way of contributing a solution to this. I'd appreciate any PRs in that area.

@wouterds
Copy link

wouterds commented Apr 4, 2018

@shivawu: No, we're talking about the same issue and fix. See thread of OP mentioning #18673 which mentions #17983 which is exactly the fix you provided, and is already included in 0.55.0.

@zen0wu
Copy link

zen0wu commented Apr 4, 2018

That's not the same patch. That one is on line 71, which fixes for devices, mine is on line 130, which fixes simulator.

@wouterds
Copy link

wouterds commented Apr 4, 2018

@shivawu: I rest my case. 😅

@zen0wu
Copy link

zen0wu commented Apr 4, 2018

I know, it's super confusing, for a minute I bought what you said, lol 😂

@grabbou
Copy link
Contributor

grabbou commented Apr 5, 2018

The regression has been introduced in this commit: 2ad3407. I am going to fix it by adding args.port (which as you can see from the diff has been removed by a mistake).

grabbou added a commit that referenced this issue Apr 5, 2018
@grabbou
Copy link
Contributor

grabbou commented Apr 5, 2018

You can find a fix here: 589eae1

@grabbou
Copy link
Contributor

grabbou commented Apr 5, 2018

@shivawu The releases are cut very carefully, but there's just too many pieces to test at one time. That's why having people to use release candidates would prevent such obvious errors from leaking into production.

Recent issues have to do with runIOS which is not part of our manual and automated testing.

@grabbou
Copy link
Contributor

grabbou commented Apr 5, 2018 via email

@wellyshen
Copy link

wellyshen commented Apr 6, 2018

@grabbou I upgraded to 0.55 and run react-native run-ios it build success but the simulator won't be launched. so wired...

@grabbou
Copy link
Contributor

grabbou commented Apr 6, 2018 via email

@wellyshen
Copy link

@grabbou Thank you for this temporary solution.

@grabbou
Copy link
Contributor

grabbou commented Apr 6, 2018 via email

@grabbou
Copy link
Contributor

grabbou commented Apr 6, 2018

Here's PR: #18721. I'll probably merge it today and once 0.55 is out, make a PR back to master to make sure it has all the fixes.

campsafari pushed a commit to exozet/react-native that referenced this issue Apr 11, 2018
Summary:
Regression introduced in facebook@2ad3407.

Fixes facebook#18681
Closes facebook#18722

Differential Revision: D7535684

Pulled By: hramos

fbshipit-source-id: 21bc79091148daba7b668965cd5becaa43117721
@mk0y
Copy link

mk0y commented May 23, 2018

This doesn't happen with React 16.3.1 and React Native 0.55.4.

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
macdoum1 pushed a commit to macdoum1/react-native that referenced this issue Jun 28, 2018
Summary:
Regression introduced in facebook@2ad3407.

Fixes facebook#18681
Closes facebook#18722

Differential Revision: D7535684

Pulled By: hramos

fbshipit-source-id: 21bc79091148daba7b668965cd5becaa43117721
grabbou added a commit to react-native-community/cli that referenced this issue Sep 26, 2018
Summary:
Regression introduced in facebook/react-native@2ad3407.

Fixes facebook/react-native#18681
Closes facebook/react-native#18722

Differential Revision: D7535684

Pulled By: hramos

fbshipit-source-id: 21bc79091148daba7b668965cd5becaa43117721
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests