0.55.x Discussion #11
Comments
turnrye
added
the
backport request
|
The android ci is still broken in master branch, which stuck my pr.Can you push to this fixed ? I tried but I know few about buck. |
|
Hey @gengjiawen, we're aware of the issue with CI and a fix is in progress. |
|
@grabbou This commit fixes a regression that broke our app (the issue was introduced with 0.54). It would be great if this fix is in the 0.55 release. |
|
@turnrye It is still broken, I don't think it's a small problem because it stuck all community pr getting merged. I really wish we can fix it asap. |
|
Yeah, I am going to spend some time this week making it green because I need to cut next release branch. Meanwhile, yet another cherry-pick request to consider: facebook/react-native#18223 (comment) |
|
Fixes an issue with invertStickyHeaders not being passed to ScrollView from SectionList / FlatList: |
|
Hopefully the ci thing will be fixed in next week :( |
|
All prior commits have been cherry-picked and we are releasing stable version now. |
|
Hey @grabbou looks like there's a Metro issue: facebook/react-native#18681 (comment) |
|
Yeah, seems to be the case. I'll look into it before making a new one.
…On Wed, 4 Apr 2018 at 17:32 Lorenzo Sciandra ***@***.***> wrote:
Hey @grabbou <https://github.com/grabbou> looks like there's a Metro
issue: facebook/react-native#18681 (comment)
<facebook/react-native#18681 (comment)>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxkMURKT248kCKcqgdoWqqFxNwihOks5tlOeZgaJpZM4S1W_m>
.
|
|
Looks like there is a PR in the making which should fix that: facebook/react-native#18700 |
|
Yeah, someone messed up |
|
Would be nice if facebook/react-native@c787e0e could be cherry-picked so that we can build using a Podspec environment. |
|
BTW looks like there's an issue with WebSockets: facebook/react-native#18696 Which I'm not sure is a 'wanted' side effect (meaning, now it's always need to pass down 3 arguments) or a real bug. |
|
I'll be cherry-picking this one:
facebook/react-native#18721 to stop issues with
`run-ios` once forever.
…On Fri, 6 Apr 2018 at 09:46 Lorenzo Sciandra ***@***.***> wrote:
BTW looks like there's an issue with WebSockets:
facebook/react-native#18696
<facebook/react-native#18696>
Which I'm not sure is a 'wanted' side effect (meaning, now it's always
need to pass down 3 arguments) or a real bug.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxofCb95s1RdnnilKSR8dUnyNQkTfks5tlx1CgaJpZM4S1W_m>
.
|
|
It looks like this commit got included in However shortly afterwards it got reverted due to a bug: In our case there are other bugs also associated with this commit (we've discovered a problem with |
|
Yet another |
|
@kelset not really something we need to address right now, but I'll keep track of it. |
|
This would resolve a long outstanding issue where Yoga (and the whole of react-native) can not be compiled when used with Cocoapods facebook/react-native#18492 |
|
Hi, really sorry if it's not my place to comment here, or if this isn't the right place for this kind of comment, but there are a lot of people waiting for this PR to be merged and released: facebook/react-native#18278, it fixes a major bug with How can we register our desire to get this released? Thanks for your help! |
|
Would be great to have the latest fix for the Podspec issue to 0.55.2 unusable otherwise. facebook/react-native@c787e0e |
|
We just released 0.55.2. I'll let it cool down for a day or two to see if
there are any other issues coming. This is obviously going to be
cherry-picked.
…On Mon, 9 Apr 2018 at 11:37 Tomas Roos ***@***.***> wrote:
Would be great to have the latest fix for the Podspec issue to 0.55.2
unusable otherwise. ***@***.***
<facebook/react-native@c787e0e>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxqEjR_Wl287cWLtXFAlAaRqRrZeuks5tmyvZgaJpZM4S1W_m>
.
|
|
This one will also have to be cherry-picked (WebSocketModule regression on Android): facebook/react-native@4b6e9d3 |
|
@grabbou do you mean there is not going to be a 0.55.4? We are still getting a lot of errors fhat would be fixed by facebook/react-native@7c5d581 . A patch release would really help us out. |
|
@jkimbo There will probably be a 0.55.4, we are not sure yet because the Babel 7 commit forced us to rediscuss the release plan for 0.55.x - 0.56.x - 0.57.x and since we still have issues on the CI there is no estimate on when the new releases will be out. Rest assured that we read the comments in the repos, but given that React Native is not as OSS-first project there are limitations in how we are able to achieve release status and atm the internal team at FB is under heavy loads of work, so if you don't want to fork the main repo & cherry pick that commit for your team you will have to wait a bit more. |
|
@kelset ok fair enough and thanks for the update. Hope I didn't mean to come across as ungrateful, I really appreciate the work you all put into the project, it's just useful to know whats going on so that I can work around if necessary 🙂 |
|
Unfortunately, recent changes broke the CI and it is impossible to release
an update right now. The 0.55.4 version is already scheduled, sent to
Circle waiting for the tests to pass. Once the fix happens, we will be able
to push it to npm.
Unfortunately, the Facebook team members in charge of this are currently on
a leave and I can't give you any estimate when this gets unblocked. We are
in touch with the team and will do our best to make it as fast as possible.
…On Mon, 30 Apr 2018 at 11:10 Jonathan Kim ***@***.***> wrote:
@kelset <https://github.com/kelset> ok fair enough and thanks for the
update. Hope I didn't mean to come across as ungrateful, I really
appreciate the work you all put into the project, it's just useful to know
whats going on so that I can work around if necessary 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxi1KaY22sIMyIMySBdSlMHcXNfJhks5tttUigaJpZM4S1W_m>
.
|
|
Will #18223 be considered for a 0.55 release? This commit fixes the empty blob error "Invalid response for blob": Noticed that 0.55.4 is tagged but hasn't been published to npm. |
|
I'll add it in. Yes, the release has some issues on the Circleci. I need to investigate that with Facebook team. Due to holidays season and couple of people from Facebook being busy, this can happen around next week. |
|
Any development on 0.55.4 release? facebook/react-native#18709 is really nasty |
|
I'll check that tomorrow. Also, an update for everyone interested: I'll be working on fixing the issues and pushing the release out there. Due to holidays and series of bank holidays it's been really unfortunate beginning of the month. Apologies for the delay if you have been blocked by any of the aforementioned issues. |
|
0.55.4 is out, thanks to @chirag04 for working on the CI breakages when I was out. I am moving to cutting next release candidate, but if you have any requests to cherry-pick, let me know. I hope I didn't miss anything we talked about earlier. |
|
Got request for the two following commits: facebook/react-native@3e534b9 and facebook/react-native@e708010 that fix |
|
Unfortunately, cherry-picking those is going to be quite tricky since there were many commits in the meantime. My attempt ended up in resolving different conflicts here and there that make me worried it's a bit dangerous process. For now I'll postpone it and focus on getting 0.56 out there. CC: @gaearon |
|
So until 0.56 we won't see a fix for the Module.close issue? Will is happen only in development or on a production release aswell? Anyway, 0.55.4, Issue still occur. |
|
There is a huge performance issue with android TextInputs that was introduced in 0.50 in this commit. Fortunately, the fix has been merged into master HERE. This issue is noticeable with a lot of text inputs. We've testing this fix and everything works as expected. Is there any way we can get this in a patch for 0.55? Since 0.56 will be a big upgrade, we don't want to take the risk of too many things changing since were are releasing our product soon. |
|
Now that @kpink224 you can try building a release based on 0.55.4 plus facebook/react-native@c6b4f9f for use in your own product. Releasing an official 0.55.5 release might be convenient for your particular case, but it would come with added burden on us maintainers that is hard to justify when the fix is already present in 0.56 and we're already working on getting ready for the 0.57 cut in just over two weeks. |
|
The idea behind discussion issues has been always to provide support for "current" stable release too. That said, especially that another issue (#27) has been opened, I am going to reopen this issue and keep available for additional comments until next stable release is cut. This is the commit that has been requested to be cherry-picked: facebook/react-native@41975f7 |
|
Regarding ^, I am aware of another person who had to fork React Native in time for a release to get this issue fixed. That said, given the minimal scope of the requested commit, I don't see any risks when it comes to backporting this change. If there is no objection, I'll schedule next update tomorrow morning, along other commits that are pending for 0.56.0-rc. |
|
@grabbou If there is going to be another 0.55.x release, can you please cherry-pick facebook/react-native@c6b4f9f ? It fixes a huge performance problem on Android. We are considering forking react native just for this commit (as 0.56 is not out, but we need to ship) |
|
@asowayan is forking React Native to get 0.55 + this commit too much trouble? Just curious - I want to understand why this approach is not common. |
|
@hramos The actual process of forking React Native and cherry picking a commit isn't too bad. However, having the infrastructure to keep that custom build of React Native is not something that everybody has set up. Sure, we could also commit the build output to our project repo or add it as a git submodule, but that creates additional complexity and clutters up a project's git repo. The React Native project already has a place to publish builds to and sharing some of these major performance / bug fixes with everybody that uses React Native as a point release would be very helpful. |
|
I am not sure I get how big of a burden this is, we are not talking about the case when React Native is forked to add functionality that is unlikely to be considered and merged into the main repo. The commit @asowayan is referring to is already part of the next release, |
|
0.56.0 has been promoted to stable right now. |
and others
Please report any major issues and commits to cherry-pick in this thread for discussion.
The text was updated successfully, but these errors were encountered: