Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent unhandled rejection with
buildCodeFrameMessage
(#567)
Summary: We encounter regular resolution issue but was not captured by throwing proper resolution error, this handles the specific case we're seeing. ``` (node:309) UnhandledPromiseRejectionWarning: Error: EISDIR: illegal operation on a directory, read at Object.readSync (fs.js:498:3) at tryReadSync (fs.js:332:20) at Object.readFileSync (fs.js:369:19) at UnableToResolveError.buildCodeFrameMessage ``` Ever since upgraded, we've seen the above error messages representing in fact an actual resolution error that should have been represented by `Unable to resolve module %s from %s: %s` messages. **Test plan** - CI Pull Request resolved: #567 Reviewed By: MichaReiser Differential Revision: D24883722 Pulled By: cpojer fbshipit-source-id: 47c6dc4445f6a6656848743c9f1987e7f3701d78
- Loading branch information