Skip to content

Commit

Permalink
Remove JSON from default asset types (#593)
Browse files Browse the repository at this point in the history
Summary:
**Summary**

JSON files are currently considered both source and assets so they are duplicated in the js bundle and in the assets copied in the final app. I think this is a better default and if someone relies on json files being also included in the bundle they can add it back in their metro config.

Fixes #487

**Test plan**

Test that json files are no longer present in my app assets and the app still works.

Pull Request resolved: #593

Reviewed By: MichaReiser

Differential Revision: D24904641

Pulled By: cpojer

fbshipit-source-id: 934b31fc022b3c32f57c88d17eaee22a2808728a
  • Loading branch information
janicduplessis authored and facebook-github-bot committed Nov 13, 2020
1 parent c2c01b2 commit 279f04f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Object {
"mp3",
"wav",
"html",
"json",
"pdf",
"yaml",
"yml",
Expand Down Expand Up @@ -169,7 +168,6 @@ Object {
"mp3",
"wav",
"html",
"json",
"pdf",
"yaml",
"yml",
Expand Down Expand Up @@ -307,7 +305,6 @@ Object {
"mp3",
"wav",
"html",
"json",
"pdf",
"yaml",
"yml",
Expand Down Expand Up @@ -445,7 +442,6 @@ Object {
"mp3",
"wav",
"html",
"json",
"pdf",
"yaml",
"yml",
Expand Down
1 change: 0 additions & 1 deletion packages/metro-config/src/defaults/defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ exports.assetExts = [
'wav',
// Document formats
'html',
'json',
'pdf',
'yaml',
'yml',
Expand Down

0 comments on commit 279f04f

Please sign in to comment.