Changes needed for FastCGI on OSX #2944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danslo
changed the title
When constructing static objects in OSX, the constructor initialization list is evaluated. This means a String object is constructed when the MemoryManager has not been initialized yet (in init_thread_locals).
|
👍 |
Closed
|
@danslo Hi. I have pulled this in for review with the understanding that the 3rd party stuff has to land first before we land it. Thanks! Internal Diff Number: D1401477 |
|
@danslo We also removed |
|
👍 |
|
This has been accepted internally. Now we just need to figure out how to handle the 3rd party updates. |
|
Updated the 3rd party pull requests. |
|
Checklist so we can keep track on what needs to happen before this can land.
|
Gownta
pushed a commit
to facebook/folly
that referenced
this pull request
Jun 27, 2014
Summary: A recent change in folly/MemoryMapping.cpp uses MAP_ANONYMOUS, which is named MAP_ANON on OSX/BSD. We need folly and third-party changes in order to land a pull request for HHVM that starts to get FastCGI running on OSX. See the checklist of the HHVM pull request here: facebook/hhvm#2944 (comment) Closes #67 GitHub Author: Daniel Sloof <[email protected]> @override-unit-failures Test Plan: fbmake runtests 100% Reviewed By: [email protected], [email protected] FB internal diff: D1407393
Gownta
pushed a commit
to facebook/folly
that referenced
this pull request
Jun 27, 2014
Summary: This prevents a linker error on OSX: ``` Undefined symbols for architecture x86_64: "folly::detail::EndianIntBase::swap(unsigned long)", referenced from: __GLOBAL__sub_I_MacAddress.cpp in libfolly.a(MacAddress.cpp.o) ld: symbol(s) not found for architecture x86_64 ``` We need folly and third-party changes in order to land a pull request for HHVM that starts to get FastCGI running on OSX. See the checklist of the HHVM pull request here: facebook/hhvm#2944 (comment) Closes #68 GitHub Author: Daniel Sloof <[email protected]> @override-unit-failures Test Plan: fbmake runtests 100% Reviewed By: [email protected], [email protected] FB internal diff: D1407426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the changes have been PRed in hhvm-third-party, @ptarjan would look at those. They must land first.