Skip to content

Commit

Permalink
Be explicit about what we're passing to Endian::big
Browse files Browse the repository at this point in the history
Summary:
This prevents a linker error on OSX:
```
Undefined symbols for architecture x86_64:
"folly::detail::EndianIntBase::swap(unsigned long)",
referenced from:
__GLOBAL__sub_I_MacAddress.cpp in libfolly.a(MacAddress.cpp.o)
ld: symbol(s) not found for architecture x86_64
```

We need folly and third-party changes in order to land a pull request for HHVM
that starts to get FastCGI running on OSX.

See the checklist of the HHVM pull request here: facebook/hhvm#2944 (comment)

Closes #68

GitHub Author: Daniel Sloof <[email protected]>

@override-unit-failures

Test Plan: fbmake runtests 100%

Reviewed By: [email protected], [email protected]

FB internal diff: D1407426
  • Loading branch information
JoelMarcey authored and Gownta committed Jun 27, 2014
1 parent 75f93a6 commit 09a81a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion folly/MacAddress.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ using std::string;

namespace folly {

const MacAddress MacAddress::BROADCAST{Endian::big(0xffffffffffffU)};
const MacAddress MacAddress::BROADCAST{Endian::big(uint64_t(0xffffffffffffU))};
const MacAddress MacAddress::ZERO;

MacAddress::MacAddress(StringPiece str) {
Expand Down

0 comments on commit 09a81a9

Please sign in to comment.