Skip to content

Commit

Permalink
Bugfix: do not erase BitRef::operator=(...) on non-mobile
Browse files Browse the repository at this point in the history
Summary:
`FOLLY_MOBILE` is always defined, though it's 1 on mobile and 0 on non-mobile.

We only want to erase for mobile to reduce binary size, though existing code will erase both.

Differential Revision: D34577423

fbshipit-source-id: 51fa74779fbbfc41394f774abe70d406b17442ed
  • Loading branch information
Mizuchi authored and facebook-github-bot committed Mar 2, 2022
1 parent 84d7e18 commit 9b68436
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion thrift/lib/cpp2/FieldRef.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class BitRef {
bit_index_(other.bit_index_),
is_atomic_(other.is_atomic_) {}

#ifdef FOLLY_MOBILE
#if FOLLY_MOBILE
// We have this attribute to prevent binary size regression
// TODO: Remove special attribute for MOBILE
FOLLY_ERASE
Expand Down

0 comments on commit 9b68436

Please sign in to comment.