Skip to content

Commit

Permalink
Add parseObject test for structs with list, set, map containers
Browse files Browse the repository at this point in the history
Summary: same as title

Reviewed By: Mizuchi

Differential Revision: D34265201

fbshipit-source-id: 95c79375f825b866abf24512d6c15bcc28736292
  • Loading branch information
rahku authored and facebook-github-bot committed Mar 2, 2022
1 parent d71d4a4 commit 84d7e18
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions thrift/conformance/cpp2/ObjectTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,15 @@ using ParseObjectTestCases = ::testing::Types<
type::double_t,
// binary_t, conformance::object has separate binary value but
// BinarySerializer serializes with type set as T_STRING
type::string_t>;
// TODO : test structs with containers, field modifiers, nested struct
type::string_t,
type::list<type::i64_t>,
type::list<type::string_t>,
type::set<type::i64_t>,
type::set<type::string_t>,
type::map<type::string_t, type::i64_t>,
type::map<type::i64_t, type::double_t>,
type::map<type::i64_t, type::set<type::string_t>>>;
// TODO : field modifiers, nested struct

TYPED_TEST_SUITE(TypedParseObjectTest, ParseObjectTestCases);

Expand Down

0 comments on commit 84d7e18

Please sign in to comment.