docs: document what should be in .gitignore #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgao19
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit 56e6312 |
1 similar comment
|
Deploy preview for docusaurus-2 ready! Built with commit 56e6312 |
|
Deploy preview for docusaurus-preview ready! Built with commit 56e6312 |
|
Deploy preview for docusaurus-2 ready! Built with commit 6e1e1eb |
|
Deploy preview for docusaurus-preview ready! Built with commit 6e1e1eb |
yangshun
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Tip: If you put "Fixes #1704" in your PR summary, the issue will be automatically closed when the PR is merged. I'm not sure if "Addresses" work but "Fixes" definitely works.
Read more: https://help.github.com/en/articles/closing-issues-using-keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addressing #1704, document what should be in .gitignore
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
NA
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)