Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change sidebar chevron icon to use svg #1211

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

yangshun
Copy link
Contributor

Motivation

Unicode rendering is font-dependent which is then system dependent. Changing it to an SVG to make it more consistent across devices.

Fixes #1207.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

screen shot 2019-01-28 at 9 43 52 pm

Related PRs

NA

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 29, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit a5f1d52

https://deploy-preview-1211--docusaurus-preview.netlify.com

1 similar comment
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit a5f1d52

https://deploy-preview-1211--docusaurus-preview.netlify.com

@yangshun yangshun merged commit 1fb1a92 into master Jan 29, 2019
@yangshun yangshun deleted the change-collapse-icon branch January 29, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants