Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsible sidebar Unicode chevron render issue #1207

Closed
CaptainT33mo opened this issue Jan 28, 2019 · 2 comments
Closed

Collapsible sidebar Unicode chevron render issue #1207

CaptainT33mo opened this issue Jan 28, 2019 · 2 comments
Assignees
@yangshun
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@CaptainT33mo
Copy link

CaptainT33mo commented Jan 28, 2019 •
edited
Loading

🐛 Bug Report

The chevron (dropdown icon) on the Collapsible Sidebar is rendering differently on different systems.

To Reproduce

I am running docursaurus on Chrome 71 for Windows 10 version 1809.

Expected behavior

This is how it should render in all systems https://i.postimg.cc/T1S3qD9h/Screen-Shot-2019-01-28-at-10-57-10-AM.png.

Actual Behavior

This is how it is rendering in my system https://i.postimg.cc/G3MWgr1P/86775128-61-E9-474-B-8-CEA-E01-DDA855-B1-F-png.jpg

Reproducible Demo

Open docursaurus on Chrome 71 for Windows 10 version 1809.

Suggestion

To make it consistent across all devices, this Unicode chevron can be replaced with SVG.

@yangshun
@yangshun yangshun added the bug An error in the Docusaurus core causing instability or issues with its execution label Jan 28, 2019
@yangshun yangshun self-assigned this Jan 28, 2019
@yangshun
Copy link
Contributor

I'll be fixing it with the SVG provided by @CaptainT33mo:

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path fill="#565656" d="M7.41 15.41L12 10.83l4.59 4.58L18 14l-6-6-6 6z"></path><path d="M0 0h24v24H0z" fill="none"></path></svg>

via inline SVG or CSS images and remove the unicode.

@yangshun yangshun mentioned this issue Jan 29, 2019
Merged
@yangshun
Copy link
Contributor

Fixed and released in v1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangshun yangshun

Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangshun @CaptainT33mo