-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove babel.config.js from init templates + website #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +4.94 kB (+0.04%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
slorber
added
pr: bug fix
This PR fixes a bug in a past release.
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
and removed
pr: bug fix
This PR fixes a bug in a past release.
labels
Sep 22, 2024
slorber
changed the title
fix: remove babel.config.js from init templates + website
chore: remove babel.config.js from init templates + website
Sep 22, 2024
slorber
changed the title
chore: remove babel.config.js from init templates + website
refactor: remove babel.config.js from init templates + website
Sep 22, 2024
Staudey
added a commit
to Staudey/help-center-docs
that referenced
this pull request
Dec 9, 2024
See also facebook/docusaurus#10514 Signed-off-by: Thomas Staudinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove babel.config.js from init templates + website
In #10511 the Babel preset has been moved to a standalone
@docusaurus/babel/preset
export.It's clean but a bit annoying as to pass E2E in Yarn PnP mode this new package needs to be added to the init templates.
Considering only a few users customize the Babel config, and that we are going to stop using Babel as the default transpiler soon, it's time to simplify the templates and remove this file. Users can still create it manually if they really need to.
Test Plan
CI
Test links
https://deploy-preview-10514--docusaurus-2.netlify.app/